Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

test: add text compliance tests - #36

Merged
larkee merged 10 commits into
mainfrom
text_compliance_test
May 12, 2021
Merged

test: add text compliance tests#36
larkee merged 10 commits into
mainfrom
text_compliance_test

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@HemangChothani

HemangChothani commented Mar 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Failed tests are fixed in #23 PR.

@skuruppu
skuruppu requested a review from vi3k6i5April 29, 2021 04:54
vi3k6i5
vi3k6i5 reviewed May 4, 2021
View reviewed changes
Comment threadtest/test_suite.py
vi3k6i5
vi3k6i5 reviewed May 4, 2021
View reviewed changes
Comment threadtest/test_suite.py Outdated
@HemangChothaniHemangChothani mentioned this pull request May 5, 2021
Merged
@HemangChothani

HemangChothani commented May 5, 2021

Copy link
Copy Markdown
ContributorAuthor

One test and cleanup of two tests are failing which will be resolved by respective PRs #23, #68.

larkee
larkee approved these changes May 11, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@larkee
larkee merged commit f3ca437 into mainMay 12, 2021
@IlyaFaer
IlyaFaer deleted the text_compliance_test branch November 17, 2021 10:03
@IlyaFaer
IlyaFaer restored the text_compliance_test branch November 17, 2021 10:03
@IlyaFaer
IlyaFaer deleted the text_compliance_test branch November 17, 2021 10:03
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vi3k6i5vi3k6i5vi3k6i5 left review comments
@larkeelarkeelarkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HemangChothani@vi3k6i5@larkee