Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix: Index on a table containing columns with no sort order fails while reflecting the table - #400

Closed
mmahmed wants to merge 1 commit into
googleapis:mainfrom
mmahmed:index_column_order_fix
Closed

fix: Index on a table containing columns with no sort order fails while reflecting the table#400
mmahmed wants to merge 1 commit into
googleapis:mainfrom
mmahmed:index_column_order_fix

Conversation

@mmahmed

@mmahmedmmahmed commented Jun 11, 2024•
edited
Loading

Copy link
Copy Markdown

Fixes#399

  1. Ignore None order as SQLAlchemy only processes ASC, DESC
  2. SQLAlchemy requires order in lowercase (asc, desc)

@google-cla

google-claBot commented Jun 11, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jun 11, 2024•
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jun 11, 2024
@mmahmedmmahmed changed the title Fixing Column Order Attributes on IndexFixing Column Order AttributesJun 11, 2024
@mmahmed
mmahmedforce-pushed the index_column_order_fix branch from 2ac9816 to 9044cc8CompareJune 11, 2024 17:44
@mmahmedmmahmed changed the title Fixing Column Order Attributesfix: Index on a table containing columns with no sort order fails while reflecting the tableJun 11, 2024
@olavloiteolavloite self-assigned this Jul 8, 2024
@olavloite

olavloite commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

@mmahmed Would you mind adding a test that fails without this change and succeeds with the change?

@mmahmed
fix: Index on a table containing columns with no sort order fails whi…
f687c12
…le reflecting the table
Fixes:
1. Ignore None order as SQLAlchemy only processes ASC, DESC
2. SQLAlchemy requires order in lowercase (asc, desc)
@mmahmed
mmahmedforce-pushed the index_column_order_fix branch from 9044cc8 to f687c12CompareJuly 9, 2024 11:03
@olavloiteolavloite mentioned this pull request Nov 4, 2024
Merged
@olavloite

olavloite commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Closing in favor of #485

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@olavloiteolavloite

Labels

api: spannerIssues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Index on a table containing columns with no sort order fails while reflecting the table

2 participants

@mmahmed@olavloite