Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: add samples - #55

Merged
IlyaFaer merged 40 commits into
mainfrom
demo_samples
Sep 17, 2021
Merged

feat: add samples#55
IlyaFaer merged 40 commits into
mainfrom
demo_samples

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Apr 19, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2021
@HemangChothaniHemangChothani changed the title feat: ass samples for create and drop tablefeat: add samples for create and drop tableApr 19, 2021
@HemangChothaniHemangChothani changed the title feat: add samples for create and drop tablefeat: add samplesApr 21, 2021
@skuruppu
skuruppu requested a review from vi3k6i5April 29, 2021 04:56
larkee
larkee reviewed Apr 29, 2021
View reviewed changes
Comment threadsamples/autocommit.py Outdated
@HemangChothani
HemangChothani marked this pull request as ready for review May 5, 2021 10:27
vi3k6i5
vi3k6i5 approved these changes May 18, 2021
View reviewed changes

@vi3k6i5vi3k6i5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some nits. Wait for @larkee to approve before submitting.

Comment threadsamples/autocommit.py Outdated
Comment threadsamples/autocommit.py Outdated
Comment threadsamples/table_fetch_rows.py Outdated
Comment threadsamples/table_fetch_rows_with_order_by.py Outdated
Comment threadsamples/table_filter_data_endswith.py Outdated
Comment threadsamples/table_filter_data_startswith.py Outdated
Comment threadsamples/table_filter_data_with_contains.py Outdated
Comment threadsamples/table_filter_data_with_like.py Outdated
larkee
larkee reviewed May 20, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all the tests into a single test file.

Also, please add a nox session to run the sample tests.

Comment threadsamples/table_create_unique_index.py Outdated
Comment threadsamples/table_fetch_rows_with_limit.py Outdated
Comment threadsamples/create_table.py Outdated
larkee
larkee reviewed May 21, 2021
View reviewed changes
Comment threadsamples/conftest.py Outdated
Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets.py Outdated
@skuruppu

skuruppu commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

@IlyaFaer can you please take over this PR and address the outstanding feedback? I think it's a good time to start merging in this PR.

@snippet-bot

snippet-botBot commented Sep 8, 2021•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 19 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@skuruppu

skuruppu commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

@IlyaFaer please ping back when you think it's ready for review again so that @larkee can take another look.

@skuruppu

skuruppu commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

I think we also need to fix the snippet-bot check. My guess is that it wants the snippet names to start with spanner_.

@google-cla

google-claBot commented Sep 9, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 9, 2021
@IlyaFaer

IlyaFaer commented Sep 9, 2021

Copy link
Copy Markdown

@googlebot I consent

@google-clagoogle-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 9, 2021
@IlyaFaer

IlyaFaer commented Sep 9, 2021•
edited
Loading

Copy link
Copy Markdown

@skuruppu, @larkee, okay, I think all the errors are fixed. Let's take another look.

@skuruppu

skuruppu commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

@larkee if you can please review this again, that would be great. We need this before we can cut a 1.0 release.

larkee
larkee reviewed Sep 16, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of minor nit fixes

Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets.py Outdated
Comment threadsamples/snippets_test.py Outdated
Comment threadsamples/snippets_test.py Outdated
Comment threadsamples/snippets_test.py Outdated
Comment threadsamples/snippets_test.py Outdated
Comment threadsamples/snippets_test.py Outdated
@IlyaFaer
IlyaFaer merged commit 406c34b into mainSep 17, 2021
@IlyaFaer
IlyaFaer deleted the demo_samples branch September 17, 2021 08:33
gcf-merge-on-greenBot pushed a commit that referenced this pull request Dec 9, 2021
@release-please
chore: release 1.0.0 (#167)
a5a1e3e
🤖 I have created a release \*beep\* \*boop\*
---
## [1.0.0](https://www.github.com/googleapis/python-spanner-sqlalchemy/compare/v0.1.0...v1.0.0) (2021-12-08)
### Features
* add code samples ([#55](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/55)) ([406c34b](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/406c34bdb21e01a1317c074fab34d87bb3d61020))
* set user-agent string to distinguish SQLAlchemy requests ([#116](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/116)) ([b5e1a21](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/b5e1a211a0475690feed36fd222a41c216d8fb82))
* support computed columns ([#139](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/139)) ([046ca97](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/046ca975778f4793e2c37d70d2a602546f9d4699)), closes [#137](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/137)
* support JSON data type ([#135](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/135)) ([184a7d5](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/184a7d576a790bbbd049fe80d589af78831379b4))
* support read_only connections ([#125](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/125)) ([352c47d](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/352c47de7bb4ea1c30b50a7fe5aee0c4d102e80e))
* support stale reads ([#146](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/146)) ([d80cb27](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/d80cb2792437731c24905c7a6919468c37779c67))
### Bug Fixes
* ALTER COLUMN NOT NULL directive fails because of inappropriate syntax ([#124](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/124)) ([c433cda](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/c433cda99fd8544810c878328a272a3a9430630f))
* array columns reflection ([#119](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/119)) ([af3b97b](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/af3b97bfa4b3ed4b223384c9ed3fa0643204d8c9)), closes [#118](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/118)
* calculate limit value correctly for offset only queries ([#160](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/160)) ([6844336](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/684433682ed29d9cde8c9898796024cefeb38493))
* correct typo in spanner_interleave_on_delete_cascade keyword ([#99](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/99)) ([a0ebf75](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/a0ebf758eda351c0a20103f9e8c2243f002b2e6e))
* raise Unimplemented error when creating temporary tables ([#159](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/159)) ([646d6ac](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/646d6ac24ccd0643b67abff9da28118e0a6f6e55))
* rollback failed exception log ([#106](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/106)) ([809e6ab](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/809e6abb29f82a7fbe6587d606e8d75283f2a2fe))
### Documentation
* add query hints example ([#153](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/153)) ([9c23804](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/9c23804746bc8c638b6c22f2cb6ea57778f7fd19))
* reformatted README titles ([#141](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/141)) ([a3ccbac](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/a3ccbac476679fe8048ed2109e5489b873278c9c))
* update benchmarks ([#155](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/155)) ([3500653](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/35006536e4de31dbcba022b73f0aadf39bc89e39))
### Miscellaneous Chores
* setup release 1.0.0 ([#165](https://www.github.com/googleapis/python-spanner-sqlalchemy/issues/165)) ([37a415d](https://www.github.com/googleapis/python-spanner-sqlalchemy/commit/37a415d071d39e99f233a1c15c1c4b89bd436570))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AVaksmanAVaksmanAwaiting requested review from AVaksman
@skuruppuskuruppuAwaiting requested review from skuruppu
2 more reviewers
@vi3k6i5vi3k6i5vi3k6i5 approved these changes
@larkeelarkeelarkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@IlyaFaerIlyaFaer

Labels

api: spannerIssues related to the googleapis/python-spanner-sqlalchemy API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HemangChothani@skuruppu@IlyaFaer@vi3k6i5@larkee@AVaksman