Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: Introduce compatibility with native namespace packages - #1036

Merged
parthea merged 5 commits into
mainfrom
migrate-to-native-namespace-packages
Dec 1, 2023
Merged

feat: Introduce compatibility with native namespace packages#1036
parthea merged 5 commits into
mainfrom
migrate-to-native-namespace-packages

Conversation

@parthea

@partheaparthea commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Nov 14, 2023
@partheaparthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: m Pull request size is medium. labels Nov 14, 2023
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Nov 14, 2023
@parthea

parthea commented Nov 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Nov 30, 2023
@parthea
parthea marked this pull request as ready for review November 30, 2023 19:15
@parthea
parthea requested review from a teamNovember 30, 2023 19:15
@partheaparthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 30, 2023
@parthea

parthea commented Nov 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Presubmit is failing with

nox > coverage report --show-missing --fail-under=99
No source for code: '/tmp/pytest-of-root/pytest-0/test_namespace_package_compat0/google/cloud/othermod.py'.
nox > Command coverage report --show-missing --fail-under=99 failed with exit code 1
nox > Session cover failed.

@partheaparthea assigned parthea and unassigned harshachintaNov 30, 2023
@parthea
parthea merged commit 5d80ab0 into mainDec 1, 2023
@parthea
parthea deleted the migrate-to-native-namespace-packages branch December 1, 2023 11:08
@release-pleaserelease-pleaseBot mentioned this pull request Dec 1, 2023
Merged
@harshachintaharshachinta mentioned this pull request Jan 16, 2024
Merged
@harshachinta

harshachinta commented Jan 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@parthea
Quick followup based on googleapis/python-spanner-sqlalchemy#375 (comment)

ModuleNotFoundError: No module named 'google.cloud.spanner_v1'

Will customers see some issue with latest release similar to how sqlalchemy repo was facing? Can you please help understand this change?

@parthea

parthea commented Jan 16, 2024

Copy link
Copy Markdown
ContributorAuthor

@harshachinta , Please see my response in googleapis/python-spanner-sqlalchemy#375 (comment)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ohmayrohmayrohmayr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@harshachinta@ohmayr