Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

docs: use autogenerated methods to get names from admin samples - #1110

Merged
rahul2393 merged 3 commits into
mainfrom
use-autogen-methods
Mar 4, 2024
Merged

docs: use autogenerated methods to get names from admin samples#1110
rahul2393 merged 3 commits into
mainfrom
use-autogen-methods

Conversation

@rahul2393

@rahul2393rahul2393 commented Mar 4, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated admin samples to remove usage of handwritten instance and database classes.

@rahul2393
rahul2393 requested a review from a team as a code ownerMarch 4, 2024 09:42
@rahul2393
rahul2393 requested review from a team and m-strzelczykMarch 4, 2024 09:42
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Mar 4, 2024
@rahul2393
rahul2393 requested review from arpan14 and harshachinta and removed request for m-strzelczykMarch 4, 2024 09:42
@rahul2393rahul2393 changed the title docs: use autogenerated methods the fetch names from admin samplesdocs: use autogenerated methods to get names from admin samplesMar 4, 2024
arpan14
arpan14 reviewed Mar 4, 2024
View reviewed changes
Comment threadsamples/samples/backup_sample.py Outdated
arpan14
arpan14 reviewed Mar 4, 2024
View reviewed changes
Comment threadsamples/samples/backup_sample.py Outdated
arpan14
arpan14 reviewed Mar 4, 2024
View reviewed changes
Comment threadsamples/samples/backup_sample.py Outdated
arpan14
arpan14 reviewed Mar 4, 2024
View reviewed changes
Comment threadsamples/samples/pg_snippets.py
Comment threadsamples/samples/snippets.py
@rahul2393
rahul2393force-pushed the use-autogen-methods branch from 61294e2 to 4723108CompareMarch 4, 2024 10:51
@rahul2393
rahul2393 merged commit 3ab74b2 into mainMar 4, 2024
@rahul2393
rahul2393 deleted the use-autogen-methods branch March 4, 2024 13:42
@release-pleaserelease-pleaseBot mentioned this pull request Mar 4, 2024
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshachintaharshachintaAwaiting requested review from harshachinta
1 more reviewer
@arpan14arpan14arpan14 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.samplesIssues that are directly related to samples.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rahul2393@arpan14