Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: use stdlib warnings module instead of a third party dependency - #1120

Merged
ankiaga merged 2 commits into
googleapis:mainfrom
asottile-sentry:stdlib-warnings
Apr 12, 2024
Merged

fix: use stdlib warnings module instead of a third party dependency#1120
ankiaga merged 2 commits into
googleapis:mainfrom
asottile-sentry:stdlib-warnings

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

see also #1037 (comment)

@asottile-sentry
asottile-sentry requested review from a teamMarch 27, 2024 15:10
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Mar 27, 2024
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 27, 2024

@ankiagaankiaga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@ankiaga
ankiaga enabled auto-merge (squash) March 28, 2024 03:35
@partheaparthea changed the title use stdlib warnings module instead of a third party dependencyfix: use stdlib warnings module instead of a third party dependencyApr 12, 2024
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@ankiaga
ankiaga merged commit 37ac4c1 into googleapis:mainApr 12, 2024
@asottile-sentry
asottile-sentry deleted the stdlib-warnings branch April 12, 2024 16:26
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@asottile-sentry@parthea@ankiaga@yoshi-kokoro