Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: resume iterator on EOS internal error - #122

Merged
larkee merged 5 commits into
googleapis:masterfrom
larkee:retry-pdml
Aug 25, 2020
Merged

fix: resume iterator on EOS internal error#122
larkee merged 5 commits into
googleapis:masterfrom
larkee:retry-pdml

Conversation

@larkee

Copy link
Copy Markdown
Contributor

Fixes#120

This fixes the same issue as googleapis/java-spanner#360.

A similar issue was encountered by bigquery-storage and was fixed in googleapis/google-cloud-python#9994.

@larkee
larkee requested review from a team, crwilcox and thiagotnunesAugust 4, 2020 05:03
@larkeelarkee self-assigned this Aug 4, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2020

@hengfenglihengfengli left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add retry for "Received unexpected EOS on DATA frame from server" error message as well.

@larkee
larkee requested a review from hengfengliAugust 7, 2020 12:13
Comment threadgoogle/cloud/spanner_v1/snapshot.py
@thiagotnunes

Copy link
Copy Markdown
Contributor

@larkee thanks for the fix, I will test it out with a long running PDML to make sure everything we need is in place!

tseaver
tseaver previously requested changes Aug 14, 2020

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change really needs unit test coverage: I'm not sure why the Kokoro build is passing without it.

Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
@thiagotnunes

Copy link
Copy Markdown
Contributor

@larkee Quick update, the PDML long running task finished successfully in production testing. Thanks for fixing this!

@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 21, 2020
larkeeand others added 2 commits August 24, 2020 11:38
@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 24, 2020
@larkee
larkee requested a review from tseaverAugust 24, 2020 07:03
@larkeelarkee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 24, 2020
@larkee
larkee dismissed tseaver’s stale reviewAugust 25, 2020 01:41

The unit test coverage is back to 100% for all files touched by this change.

@larkee
larkee requested a review from hengfengliAugust 25, 2020 01:41

@hengfenglihengfengli left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@larkee
larkee merged commit 45a1538 into googleapis:masterAug 25, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spanner-client: Retry PDML on "Received unexpected EOS on DATA frame from server"

4 participants

@larkee@thiagotnunes@tseaver@hengfengli