Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

perf: remove repeated GetSession calls for FixedSizePool - #1252

Merged
olavloite merged 22 commits into
mainfrom
remove-repeated-get-session-calls
Dec 5, 2024
Merged

perf: remove repeated GetSession calls for FixedSizePool#1252
olavloite merged 22 commits into
mainfrom
remove-repeated-get-session-calls

Conversation

@olavloite

@olavloiteolavloite commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Add a _last_use_time to Session and use this to determine whether the FixedSizePool should check whether the session still exists, and whether it should be replaced. This significantly reduces the number of times that GetSession is called when using FixedSizePool.

@olavloite
test: add mock server tests
f6f6080
@olavloite
chore: move to testing folder + fix formatting
10bff97
@olavloite
refactor: move mock server tests to separate directory
e736201
@olavloite
feat: add database admin service
d51b098
Adds a DatabaseAdminService to the mock server and sets up a basic
test case for this.
Also removes the generated stubs in the grpc files, as these are
not needed.
@olavloite
test: add DDL test
505442f
@olavloite
Merge branch 'main' into mock-server-tests
852221d
@olavloite
Merge branch 'main' into mock-server-tests
dab1f48
@olavloite
test: add async client tests
21557e0
@olavloite
Merge branch 'main' into mock-server-tests
95b6cd6
@olavloite
chore: remove async + add transaction handling
39a11d0
@olavloite
chore: cleanup
ddb44a3
@olavloite
perf: remove repeated GetSession calls for FixedSizePool
14fd3ff
Add a _last_use_time to Session and use this to determine whether the
FixedSizePool should check whether the session still exists, and whether
it should be replaced. This significantly reduces the number of times that
GetSession is called when using FixedSizePool.
@olavloite
olavloite requested review from a teamDecember 4, 2024 15:22
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 4, 2024
Base automatically changed from mock-server-tests to mainDecember 5, 2024 10:17
harshachinta
harshachinta reviewed Dec 5, 2024
View reviewed changes
Comment threadtests/unit/test_pool.py
Comment threadgoogle/cloud/spanner_v1/session.py Outdated
@olavloiteolavloite added the owlbot:ignore instruct owl-bot to ignore a PR label Dec 5, 2024
harshachinta
harshachinta approved these changes Dec 5, 2024
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/session.py Outdated
@olavloite
olavloite enabled auto-merge (squash) December 5, 2024 13:57
@olavloite
olavloite merged commit c064815 into mainDec 5, 2024
@olavloite
olavloite deleted the remove-repeated-get-session-calls branch December 5, 2024 15:09
@release-pleaserelease-pleaseBot mentioned this pull request Dec 5, 2024
Merged
@olavloiteolavloite mentioned this pull request Dec 5, 2024
Closed
@olavloiteolavloite mentioned this pull request Dec 24, 2024
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@harshachintaharshachintaharshachinta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rahul2393rahul2393

Labels

api: spannerIssues related to the googleapis/python-spanner API.owlbot:ignoreinstruct owl-bot to ignore a PRsize: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@harshachinta@rahul2393