Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

chore(x-goog-spanner-request-id): plug in functionality after test scaffolding - #1367

Merged
olavloite merged 4 commits into
googleapis:mainfrom
odeke-em:x-goog-spanner-request-id-add-functionality-after-scaffolding
May 17, 2025
Merged

chore(x-goog-spanner-request-id): plug in functionality after test scaffolding#1367
olavloite merged 4 commits into
googleapis:mainfrom
odeke-em:x-goog-spanner-request-id-add-functionality-after-scaffolding

Conversation

@odeke-em

@odeke-emodeke-em commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

This change chops down the load of the large changes for x-goog-spanner-request-id. It depends on PR #1366 and should only be merged after that PR.

Updates googleapis/google-cloud-python#15905
Requires PR #1366

@odeke-em
odeke-em requested review from a teamApril 30, 2025 19:38
@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Apr 30, 2025
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Apr 30, 2025
@odeke-em
odeke-emforce-pushed the x-goog-spanner-request-id-add-functionality-after-scaffolding branch from 9c76b52 to f82ef0cCompareApril 30, 2025 19:39
@odeke-em
odeke-emforce-pushed the x-goog-spanner-request-id-add-functionality-after-scaffolding branch 2 times, most recently from 9b9a263 to b8b1591CompareMay 8, 2025 10:46
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels May 12, 2025
@odeke-em
chore(x-goog-spanner-request-id): plug in functionality after test sc…
2c44ec8
…affolding
This change chops down the load of the large changes for
x-goog-spanner-request-id. It depends on PR googleapis#1366 and should
only be merged after that PR.
Updates #1261
Requires PR googleapis#1366
@odeke-em
odeke-emforce-pushed the x-goog-spanner-request-id-add-functionality-after-scaffolding branch from d513594 to 2c44ec8CompareMay 12, 2025 21:43
@olavloiteolavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2025
@odeke-em

odeke-em commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@rahul2393@olavloite@harshachinta@sakthivelmanii kindly help run the bots. Thank you.

olavloite
olavloite reviewed May 14, 2025
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py Outdated
Comment threadgoogle/cloud/spanner_v1/database.py Outdated
Comment threadgoogle/cloud/spanner_v1/database.py Outdated
Comment threadgoogle/cloud/spanner_v1/session.py Outdated
Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
Comment threadgoogle/cloud/spanner_v1/snapshot.py Outdated
Comment threadtests/unit/test_spanner.py Outdated
@odeke-em
odeke-em requested a review from olavloiteMay 14, 2025 12:12
@odeke-em
odeke-emforce-pushed the x-goog-spanner-request-id-add-functionality-after-scaffolding branch 2 times, most recently from 1b0d745 to c8da8d8CompareMay 14, 2025 12:18
@odeke-em

odeke-em commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

@olavloite thank you for the first round of review. I have addressed it, please take another look and kindly help me re-run the bots.

@odeke-em
odeke-emforce-pushed the x-goog-spanner-request-id-add-functionality-after-scaffolding branch from c8da8d8 to 6f1ffffCompareMay 14, 2025 12:52
@olavloiteolavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2025
@olavloiteolavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2025
@olavloite
olavloite merged commit 3a91671 into googleapis:mainMay 17, 2025
@odeke-em
odeke-em deleted the x-goog-spanner-request-id-add-functionality-after-scaffolding branch May 17, 2025 10:03
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@olavloiteolavloiteolavloite approved these changes
@sakthivelmaniisakthivelmaniisakthivelmanii approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@surbhigarg92surbhigarg92

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@odeke-em@olavloite@sakthivelmanii@surbhigarg92@yoshi-kokoro