Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 103
feat: add support for experimental host#1452
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e942156
feat: add support for experimental host
sagnghos 18cb30a
fix lint issues
sagnghos 2ffe530
Merge branch 'main' into sagnghos/experimentalHost
rahul2393 6bd4643
fixed unit tests
sagnghos c07c0b2
added docmentation for new client option
sagnghos 9b443be
Merge branch 'main' into sagnghos/experimentalHost
rahul2393 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -176,6 +176,11 @@ class Client(ClientWithProject): | ||
| or :class:`dict` | ||
| :param default_transaction_options: (Optional) Default options to use for all transactions. | ||
| :type experimental_host: str | ||
| :param experimental_host: (Optional) The endpoint for a spanner experimental host deployment. | ||
| This is intended only for experimental host spanner endpoints. | ||
| If set, this will override the `api_endpoint` in `client_options`. | ||
| :raises: :class:`ValueError <exceptions.ValueError>` if both ``read_only`` | ||
| and ``admin`` are :data:`True` | ||
| """ | ||
| @@ -200,8 +205,10 @@ def __init__( | ||
| directed_read_options=None, | ||
| observability_options=None, | ||
| default_transaction_options: Optional[DefaultTransactionOptions] = None, | ||
| experimental_host=None, | ||
| ): | ||
| self._emulator_host = _get_spanner_emulator_host() | ||
| self._experimental_host = experimental_host | ||
sagnghos marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| if client_options and type(client_options) is dict: | ||
| self._client_options = google.api_core.client_options.from_dict( | ||
| @@ -212,6 +219,8 @@ def __init__( | ||
| if self._emulator_host: | ||
| credentials = AnonymousCredentials() | ||
| elif self._experimental_host: | ||
| credentials = AnonymousCredentials() | ||
| elif isinstance(credentials, AnonymousCredentials): | ||
| self._emulator_host = self._client_options.api_endpoint | ||
| @@ -324,6 +333,15 @@ def instance_admin_api(self): | ||
| client_options=self._client_options, | ||
| transport=transport, | ||
| ) | ||
| elif self._experimental_host: | ||
| transport = InstanceAdminGrpcTransport( | ||
| channel=grpc.insecure_channel(target=self._experimental_host) | ||
| ) | ||
| self._instance_admin_api = InstanceAdminClient( | ||
| client_info=self._client_info, | ||
| client_options=self._client_options, | ||
| transport=transport, | ||
| ) | ||
| else: | ||
| self._instance_admin_api = InstanceAdminClient( | ||
| credentials=self.credentials, | ||
| @@ -345,6 +363,15 @@ def database_admin_api(self): | ||
| client_options=self._client_options, | ||
| transport=transport, | ||
| ) | ||
| elif self._experimental_host: | ||
| transport = DatabaseAdminGrpcTransport( | ||
| channel=grpc.insecure_channel(target=self._experimental_host) | ||
| ) | ||
| self._database_admin_api = DatabaseAdminClient( | ||
| client_info=self._client_info, | ||
| client_options=self._client_options, | ||
| transport=transport, | ||
| ) | ||
| else: | ||
| self._database_admin_api = DatabaseAdminClient( | ||
| credentials=self.credentials, | ||
| @@ -485,6 +512,7 @@ def instance( | ||
| self._emulator_host, | ||
| labels, | ||
| processing_units, | ||
| self._experimental_host, | ||
| ) | ||
| def list_instances(self, filter_="", page_size=None): | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -62,9 +62,10 @@ class DatabaseSessionsManager(object): | ||
| _MAINTENANCE_THREAD_POLLING_INTERVAL = timedelta(minutes=10) | ||
| _MAINTENANCE_THREAD_REFRESH_INTERVAL = timedelta(days=7) | ||
| def __init__(self, database, pool): | ||
| def __init__(self, database, pool, is_experimental_host: bool = False): | ||
| self._database = database | ||
| self._pool = pool | ||
| self._is_experimental_host = is_experimental_host | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep the name consistent everywhere | ||
| # Declare multiplexed session attributes. When a multiplexed session for the | ||
| # database session manager is created, a maintenance thread is initialized to | ||
| @@ -88,7 +89,7 @@ def get_session(self, transaction_type: TransactionType) -> Session: | ||
| session = ( | ||
| self._get_multiplexed_session() | ||
| if self._use_multiplexed(transaction_type) | ||
| if self._use_multiplexed(transaction_type) or self._is_experimental_host | ||
| else self._pool.get() | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.