Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: DB-API driver + unit tests - #160
Merged
Merged
Conversation
mf2199
marked this pull request as ready for review
November 2, 2020 19:42
c24t
approved these changes
Nov 2, 2020
Contributor
There was a problem hiding this comment.
LGTM, we'll need a PR in https://github.com/googleapis/python-spanner-django to remove spanner_dbapi and then coordinate releasees. We can follow up with tests for 2.x.
larkee
suggested changes
Nov 6, 2020
larkee
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 Just one concern about NUMERIC loss of precision.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
larkee
approved these changes
Nov 10, 2020
gcf-merge-on-greenBot
pushed a commit
that referenced
this pull request
Nov 11, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-spanner/compare/v1.19.1...v2.0.0) (2020-11-11) ### ⚠ BREAKING CHANGES * migrate to v2.0.0 (#147) ### Features * DB-API driver + unit tests ([#160](https://www.github.com/googleapis/python-spanner/issues/160)) ([2493fa1](https://www.github.com/googleapis/python-spanner/commit/2493fa1725d2d613f6c064637a4e215ee66255e3)) * migrate to v2.0.0 ([#147](https://www.github.com/googleapis/python-spanner/issues/147)) ([bf4b278](https://www.github.com/googleapis/python-spanner/commit/bf4b27827494e3dc33b1e4333dfe147a36a486b3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced Jun 17, 2021
This was referenced Jun 25, 2021
This was referenced Jul 2, 2021
This was referenced Jul 22, 2021
This was referenced Jul 30, 2021
This was referenced Apr 17, 2024
parthea pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 6, 2026
BREAKING CHANGE: DBAPI code was moved into python-spanner in googleapis/python-spanner#160. This change removes it from this repo and bumps the dependency on python-spanner to 2.0.0, the first released version to include DBAPI.
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DB-API driver refactored from python-spanner-django repository, prior to its beta-release.
Some additional changes have been made to skip unit tests found incompatible with Python 2.