Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: add samples for PITR - #222

Merged
gcf-merge-on-green[bot] merged 12 commits into
masterfrom
pitr-samples
Feb 25, 2021
Merged

feat: add samples for PITR#222
gcf-merge-on-green[bot] merged 12 commits into
masterfrom
pitr-samples

Conversation

@zoercai

@zoercaizoercai commented Feb 4, 2021•
edited by larkee
Loading

Copy link
Copy Markdown
Contributor

This PR modifies existing samples and adds a sample to show how to use the PITR feature.

@zoercai
zoercai requested a review from a teamFebruary 4, 2021 05:52
@zoercai
zoercai requested a review from a team as a code ownerFebruary 4, 2021 05:52
@zoercai
zoercai requested review from dinagraves and removed request for a teamFebruary 4, 2021 05:52
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@product-auto-labelproduct-auto-labelBot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Feb 4, 2021
@snippet-bot

snippet-botBot commented Feb 4, 2021•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@zoercaizoercai added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 4, 2021
@thiagotnunesthiagotnunes changed the title Add PITR samplesfeat: adds samples for PITRFeb 4, 2021
thiagotnunes
thiagotnunes approved these changes Feb 4, 2021
View reviewed changes

@thiagotnunesthiagotnunes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagotnunes

thiagotnunes commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

This should only be merged after #148 is merged.

@larkee

larkee commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

This should only be merged after #148 is merged.

This should be merged after a release that contains #148 to avoid breaking sample tests that run using the latest release.

@larkeelarkee changed the title feat: adds samples for PITRfeat: add samples for PITRFeb 5, 2021
@larkeelarkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
larkee
larkee suggested changes Feb 23, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new samples to backup_sample.py. Python does not split individual samples into separate files like other languages.

@zoercai
zoercai requested a review from larkeeFebruary 24, 2021 03:38
larkee
larkee suggested changes Feb 24, 2021
View reviewed changes
Comment threadsamples/samples/backup_sample.py Outdated
Comment threadsamples/samples/backup_sample.py Outdated
Comment threadsamples/samples/backup_sample.py Outdated
@zoercai
zoercai requested a review from larkeeFebruary 24, 2021 06:46
larkee
larkee suggested changes Feb 24, 2021
View reviewed changes
Comment threadsamples/samples/backup_sample.py Outdated
Comment threadsamples/samples/backup_sample_test.py Outdated
Comment threadsamples/samples/backup_sample_test.py Outdated
@zoercai
zoercai requested a review from larkeeFebruary 24, 2021 23:59
larkee
larkee reviewed Feb 25, 2021
View reviewed changes
Comment threadsamples/samples/backup_sample_test.py Outdated
@zoercai
zoercai requested a review from larkeeFebruary 25, 2021 00:58
larkee
larkee approved these changes Feb 25, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the line is reverted 👍

Comment threadsamples/samples/backup_sample.py Outdated
@zoercaizoercai added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 25, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit da146b7 into masterFeb 25, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the pitr-samples branch February 25, 2021 01:42
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 25, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Mar 8, 2021
@release-please
chore: release 3.2.0 (#244)
215aaae
🤖 I have created a release \*beep\* \*boop\* ---
## [3.2.0](https://www.github.com/googleapis/python-spanner/compare/v3.1.0...v3.2.0) (2021-03-02)
### Features
* add `Database.list_tables` method ([#219](https://www.github.com/googleapis/python-spanner/issues/219)) ([28bde8c](https://www.github.com/googleapis/python-spanner/commit/28bde8c18fd76b25ec1b64c44db7c1600255256f))
* add sample for commit stats ([#241](https://www.github.com/googleapis/python-spanner/issues/241)) ([1343656](https://www.github.com/googleapis/python-spanner/commit/1343656ad43dbc41c119b652d8fe9360fa2b0e78))
* add samples for PITR ([#222](https://www.github.com/googleapis/python-spanner/issues/222)) ([da146b7](https://www.github.com/googleapis/python-spanner/commit/da146b7a5d1d2ab6795c53301656d39e5594962f))
### Bug Fixes
* remove print statement ([#245](https://www.github.com/googleapis/python-spanner/issues/245)) ([1c2a64f](https://www.github.com/googleapis/python-spanner/commit/1c2a64fd06404bb7c2dfb4a8f65edd64c7710340))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@dependabotdependabotBot mentioned this pull request Mar 15, 2021
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dinagravesdinagravesAwaiting requested review from dinagraves
2 more reviewers
@thiagotnunesthiagotnunesthiagotnunes approved these changes
@larkeelarkeelarkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zoercai@thiagotnunes@larkee@yoshi-kokoro