Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix(db_api): use correct connection attribute when handling Aborted errors - #228

Merged
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_225
Feb 15, 2021
Merged

fix(db_api): use correct connection attribute when handling Aborted errors#228
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_225

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes#225

This PR include error related unit tests to raise the coverage of "DB_API".

@HemangChothani
HemangChothani requested review from a team and c24tFebruary 8, 2021 10:57
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@larkee

Copy link
Copy Markdown
Contributor

Thank you for making this PR! Improved test coverage is always appreciated. Are there plans to improve the coverage for google/cloud/spanner_dbapi/utils.py and google/cloud/spanner_dbapi/connection.py as well?

@HemangChothani

Copy link
Copy Markdown
ContributorAuthor

Yes, I will open other PR soon.

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@larkeelarkee changed the title fix(db_api): connection attribute of connection class and include related unit testsfix(db_api): use correct connection attribute when handling Aborted errorsFeb 15, 2021
@larkee
larkee merged commit 4afea77 into googleapis:masterFeb 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db_api: cursor class doesn't have _connection attribute

2 participants

@HemangChothani@larkee