Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix(db_api): update parse_util output for homogeneous statements - #233

Merged
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_232
Feb 18, 2021
Merged

fix(db_api): update parse_util output for homogeneous statements#233
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_232

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

Fixes#232

@HemangChothani
HemangChothani requested review from a team, c24t and larkeeFebruary 11, 2021 12:17
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2021
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 11, 2021
larkee
larkee reviewed Feb 15, 2021
View reviewed changes
Comment threadgoogle/cloud/spanner_dbapi/parse_utils.py
"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}

@larkeelarkeeFeb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change?

@HemangChothaniHemangChothaniFeb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope i think.

@larkeelarkeeFeb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

@larkee

larkee commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Please update the title to be more descriptive i.e. fix: update parse_util output for homogeneous statements

The PR title will be used in the release notes.

@larkeelarkee mentioned this pull request Feb 15, 2021
Merged
@HemangChothaniHemangChothani changed the title fix: fix execute insert for homogeneous statementfix: update parse_util output for homogeneous statementsFeb 15, 2021
larkee
larkee reviewed Feb 15, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the title is updated

Comment threadgoogle/cloud/spanner_dbapi/parse_utils.py
"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}

@larkeelarkeeFeb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

@HemangChothani

HemangChothani commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

LGTM once the title is updated

I have changed the title.

@larkeelarkee changed the title fix: update parse_util output for homogeneous statementsfix(db_api): update parse_util output for homogeneous statementsFeb 16, 2021
@larkee
larkee merged commit 36b12a7 into googleapis:masterFeb 18, 2021
IlyaFaer pushed a commit to MaxxleLLC/python-spanner that referenced this pull request Mar 22, 2021
IlyaFaer
fix: revertgoogleapis#233
21a82cb
@IlyaFaerIlyaFaer mentioned this pull request Mar 22, 2021
Merged
larkee pushed a commit that referenced this pull request Mar 24, 2021
Ilya Gurov
fix(db_api): revert Mutations API usage (#285)
e5d4901
* fix: revert #233
* update docstrings
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@c24tc24tAwaiting requested review from c24t
1 more reviewer
@larkeelarkeelarkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

db_api: parse_insert method doesn't work as expected

2 participants

@HemangChothani@larkee