Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: set a separate user agent for the DB API - #566

Merged
larkee merged 3 commits into
googleapis:mainfrom
MaxxleLLC:user_agent
Sep 13, 2021
Merged

feat: set a separate user agent for the DB API#566
larkee merged 3 commits into
googleapis:mainfrom
MaxxleLLC:user_agent

Conversation

@IlyaFaer

Copy link
Copy Markdown

@IlyaFaerIlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 9, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2021
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner API. label Sep 9, 2021
Comment threadgoogle/cloud/spanner_dbapi/version.py
@IlyaFaer
IlyaFaer marked this pull request as ready for review September 9, 2021 15:39
@IlyaFaer
IlyaFaer requested review from a team and skuruppuSeptember 9, 2021 15:39
@larkeelarkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@skuruppuskuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2021
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@larkeelarkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@IlyaFaer

IlyaFaer commented Sep 10, 2021

Copy link
Copy Markdown
Author

A couple of sample tests failed with google.api_core.exceptions.RetryError: Deadline of 240.0s exceeded - doesn't seem to be related

@larkee
larkee merged commit b5f977e into googleapis:mainSep 13, 2021
@IlyaFaer
IlyaFaer deleted the user_agent branch September 13, 2021 10:44
gcf-merge-on-greenBot pushed a commit that referenced this pull request Sep 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner API.cla: yesThis human has signed the Contributor License Agreement.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: set user-agent string to distinguish SQLAlchemy requests

4 participants

@IlyaFaer@skuruppu@larkee@yoshi-kokoro