Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: Adding reason, domain, metadata & error_details fields in Custom Exceptions for additional info - #804

Merged
asthamohta merged 5 commits into
googleapis:mainfrom
gauravpurohit06:error_details_improvement
Sep 26, 2022
Merged

feat: Adding reason, domain, metadata & error_details fields in Custom Exceptions for additional info#804
asthamohta merged 5 commits into
googleapis:mainfrom
gauravpurohit06:error_details_improvement

Conversation

@gauravpurohit06

@gauravpurohit06gauravpurohit06 commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

Adding following properties under DBAPI exceptions to provide additional error info.
-reason
-domain
-metadata
-details

@gauravpurohit06
gauravpurohit06 requested review from a teamSeptember 12, 2022 11:09
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Sep 12, 2022
IlyaFaer
IlyaFaer reviewed Sep 20, 2022
View reviewed changes
Comment threadgoogle/cloud/spanner_dbapi/exceptions.py
asthamohta
asthamohta reviewed Sep 21, 2022
View reviewed changes
Comment threadgoogle/cloud/spanner_dbapi/exceptions.py Outdated
@asthamohta
asthamohta merged commit 2a74060 into googleapis:mainSep 26, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Sep 26, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@IlyaFaerIlyaFaerIlyaFaer left review comments
@asthamohtaasthamohtaasthamohta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gauravpurohit06@IlyaFaer@asthamohta