feat: add support for updateDatabase in Cloud Spanner by aayushimalik · Pull Request #914 · googleapis/python-spanner

aayushimalik · 2023-03-16T11:22:36Z

No description provided.

grace223 · 2023-03-18T10:07:46Z

 from google.iam.v1 import options_pb2
+from google.protobuf.field_mask_pb2 import FieldMask

 from google.cloud.spanner_admin_database_v1 import CreateDatabaseRequest


grace223 · 2023-03-18T10:08:53Z

 import mock
 from google.api_core import gapic_v1
+from google.cloud.spanner_admin_database_v1 import Database as DatabasePB
 from google.cloud.spanner_v1.param_types import INT64


snippet-bot · 2023-03-21T09:49:25Z

Here is the summary of changes.

You are about to add 1 region tag.

samples/samples/snippets.py:199, tag spanner_update_database

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

asthamohta · 2023-04-21T08:18:18Z

 self._database_dialect = database_dialect
 self._database_role = database_role
+ self._enable_drop_protection = enable_drop_protection
+ self._reconciling = False


I can't see any place where this value is updated?

This is updated at line 359 of this file, using the property setter.

I am referring to reconciling

…p-database-protection # Conflicts: # google/cloud/spanner_v1/database.py

…otection

rajatbhatta · 2023-05-16T09:17:31Z

Added samples from #917 to here (for single merge). Both PRs are approved.

feat: drop database protection
e4163d0

aayushimalik requested review from a teamMarch 16, 2023 11:22

product-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 16, 2023

grace223 approved these changes Mar 18, 2023
View reviewed changes

aayushimalik requested a review from a team as a code owner March 21, 2023 09:49

aayushimalik requested a review from parthea March 21, 2023 09:49

product-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 21, 2023

aayushimalik force-pushed the drop-database-protection branch from 9ca2103 to e4163d0Compare March 21, 2023 10:26

product-auto-labelBot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Mar 21, 2023

aayushimalik added 2 commits March 21, 2023 11:09

feat: drop database protection sample and sample test
1d64d5d

Make sample changes follow client lib spec
ee653cd

rajatbhatta reviewed Apr 4, 2023
View reviewed changes

Comment threadgoogle/cloud/spanner_v1/database.py Outdated

rajatbhatta changed the title ~~feat: drop database protection~~feat: add support for updateDatabase in Cloud SpannerApr 4, 2023

rajatbhatta requested a review from asthamohta April 4, 2023 17:21

asthamohta reviewed Apr 4, 2023
View reviewed changes

Comment threadgoogle/cloud/spanner_v1/database.py Outdated

asthamohta reviewed Apr 4, 2023
View reviewed changes

Comment threadgoogle/cloud/spanner_v1/database.py Outdated

aayushimalik added 3 commits April 12, 2023 05:32

Reviewer suggested changes.
167f68b

Add test for invalid UpdateDatabaseRequest.
b27fd76

Update field name drop_protection_enabled to enable_drop_protection.
545cd8c

asthamohta reviewed Apr 21, 2023
View reviewed changes

Comment threadgoogle/cloud/spanner_v1/database.py

asthamohta reviewed Apr 21, 2023
View reviewed changes

Comment threadtests/system/test_database_api.py Outdated

Formatting fix.
430543c

asthamohta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 26, 2023

asthamohta approved these changes Apr 26, 2023
View reviewed changes

aayushimalik added 2 commits May 11, 2023 09:41

Update the reconciling field when reloading a database.
babd236

Merge remote-tracking branch 'googleapi-python-spanner/main' into dro…
5420284
…p-database-protection # Conflicts: # google/cloud/spanner_v1/database.py

rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 12, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023

linting fix
a700a02

rajatbhatta enabled auto-merge (squash) May 16, 2023 06:24

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

Merge branch 'main' into drop-database-protection
effbfbf

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

rajatbhattaand others added 3 commits May 16, 2023 09:10

Merge branch 'main' into drop-database-protection
8ad7820

Merge branch 'googleapis:main' into drop-database-protection-samples
23c2014

Merge branch 'drop-database-protection-samples' into drop-database-pr…
970cb8a
…otection

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023

rajatbhatta merged commit 6c7ad29 into googleapis:mainMay 16, 2023

release-pleaseBot mentioned this pull request May 16, 2023
chore(main): release 3.35.0 #944
Merged

rajatbhatta mentioned this pull request May 16, 2023
samples: add support for updateDatabase in Cloud Spanner #917
Closed

Navigation Menu

Uh oh!

feat: add support for updateDatabase in Cloud Spanner - #914

feat: add support for updateDatabase in Cloud Spanner#914
rajatbhatta merged 14 commits into
googleapis:mainfrom
aayushimalik:drop-database-protection

aayushimalik commented Mar 16, 2023

Uh oh!

grace223Mar 18, 2023

Uh oh!

grace223Mar 18, 2023

Uh oh!

snippet-botBot commented Mar 21, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asthamohtaApr 21, 2023

Uh oh!

aayushimalikApr 21, 2023

Uh oh!

asthamohtaApr 26, 2023

Uh oh!

Uh oh!

Uh oh!

rajatbhatta commented May 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aayushimalik commented Mar 16, 2023

Uh oh!

grace223Mar 18, 2023

Choose a reason for hiding this comment

Uh oh!

grace223Mar 18, 2023

Choose a reason for hiding this comment

Uh oh!

snippet-botBot commented Mar 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asthamohtaApr 21, 2023

Choose a reason for hiding this comment

Uh oh!

aayushimalikApr 21, 2023

Choose a reason for hiding this comment

Uh oh!

asthamohtaApr 26, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rajatbhatta commented May 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

snippet-botBot commented Mar 21, 2023•
edited
Loading