Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add if*generation*match args into Bucket.delete_blobs() - #130
Merged
gcf-merge-on-green[bot] merged 26 commits intoJun 15, 2020
Merged
Conversation
added 11 commits
May 1, 2020 12:19
IlyaFaer
commented
May 5, 2020
Author
This should be merged only after merging #123, as this branch based on the one from PR 123. |
IlyaFaer
commented
May 5, 2020
| if_generation_not_match=next(if_generation_not_match, None), | ||
| if_metageneration_match=next(if_metageneration_match, None), | ||
| if_metageneration_not_match=next(if_metageneration_not_match, None), | ||
| ) |
Author
There was a problem hiding this comment.
In this method we're converting args into iterators to be able to take next item (or None if there is no next item, or items at all) with a single line.
IlyaFaer
marked this pull request as ready for review
May 5, 2020 14:01
IlyaFaer
commented
May 5, 2020
Author
I don't see any system tests for this method. Maybe it should be added to check generation match args are working fine? |
This reverts commit b982094.
added 3 commits
May 12, 2020 10:57
andrewsg
commented
May 20, 2020
Contributor
Since #123 has been merged, I be ready to review this once the branch is updated and conflicts resolved. Thanks! |
IlyaFaer
commented
May 21, 2020
Author
@andrewsg, I've pushed some changes to check if generation match args length differs from |
andrewsg
suggested changes
Jun 2, 2020
Uh oh!
There was an error while loading. Please reload this page.
andrewsg
approved these changes
Jun 15, 2020
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #127