Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add *generation*match args into Blob.compose() - #122

Merged
frankyn merged 14 commits into
googleapis:masterfrom
MaxxleLLC:compose_generation_match
Jun 9, 2020
Merged

feat: add *generation*match args into Blob.compose()#122
frankyn merged 14 commits into
googleapis:masterfrom
MaxxleLLC:compose_generation_match

Conversation

@IlyaFaer

@IlyaFaerIlyaFaer commented Apr 30, 2020•
edited
Loading

Copy link
Copy Markdown

Add ifGenerationMatch and ifMetagenerationMatch arguments into Blob.compose() method.
Towards #127

@IlyaFaerIlyaFaer added api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 30, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2020
@IlyaFaer
IlyaFaer requested a review from frankynApril 30, 2020 13:35
@IlyaFaer
IlyaFaer marked this pull request as ready for review April 30, 2020 13:35
@frankynfrankyn mentioned this pull request May 4, 2020
Closed
andrewsg
andrewsg suggested changes May 5, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/blob.py
Comment threadtests/system/test_system.py
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
frankyn
frankyn suggested changes May 13, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/blob.py
andrewsg
andrewsg suggested changes May 20, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/blob.py
frankyn
frankyn approved these changes May 27, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @andrewsg approval.

@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
andrewsg
andrewsg approved these changes Jun 2, 2020
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsgandrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2020
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@andrewsgandrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@frankyn
frankyn merged commit dc01c59 into googleapis:masterJun 9, 2020
@IlyaFaer
IlyaFaer deleted the compose_generation_match branch June 10, 2020 07:26
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@frankyn@cojenco
feat: add *generation*match args into Blob.compose() (googleapis#122)
0a3ddc5
* feat: add *generation*match args into Blob.compose()
* add test case with error
* new compose surface
* Revert "new compose surface"
This reverts commit 2ddda40.
* add an error for different length args, add a usage example
* add condition to avoid sending params with None
* specify comments
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@frankyn@cojenco
feat: add *generation*match args into Blob.compose() (googleapis#122)
fb67895
* feat: add *generation*match args into Blob.compose()
* add test case with error
* new compose surface
* Revert "new compose surface"
This reverts commit 2ddda40.
* add an error for different length args, add a usage example
* add condition to avoid sending params with None
* specify comments
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@andrewsgandrewsgandrewsg approved these changes
@frankynfrankynfrankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IlyaFaer@andrewsg@frankyn@googlebot@yoshi-kokoro