Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix(storage): remove expiration strict conversion - #106

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_105
Apr 16, 2020
Merged

fix(storage): remove expiration strict conversion#106
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_105

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

Fixes#105

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
@HemangChothani

HemangChothani commented Apr 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Doc is failing because of 100 issue, so first need to merge 103 PR.

frankyn
frankyn approved these changes Apr 14, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HemangChothani LGTM!

(Thanks @andrewsg for picking up the review)

@frankynfrankyn added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 16, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@gcf-merge-on-green

gcf-merge-on-greenBot commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green

gcf-merge-on-greenBot commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 9550dad into googleapis:masterApr 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
3bd5bac
Fixesgoogleapis#105
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
0702055
Fixesgoogleapis#105
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
2 more reviewers
@andrewsgandrewsgandrewsg approved these changes
@frankynfrankynfrankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use converted expiration parameter for signed_query_params to generate_signed_url_v2

5 participants

@HemangChothani@andrewsg@frankyn@googlebot@yoshi-kokoro