Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Feat: download_to_filename deletes the empty file on a 404 - #1394

Merged
andrewsg merged 1 commit into
mainfrom
3.0-filename-404-cleanup
Dec 11, 2024
Merged

Feat: download_to_filename deletes the empty file on a 404#1394
andrewsg merged 1 commit into
mainfrom
3.0-filename-404-cleanup

Conversation

@andrewsg

@andrewsgandrewsg commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Fixes#1342 🦕

BEGIN_COMMIT_OVERRIDE
feat!: Blob.download_to_filename() deletes the empty destination file on a 404
END_COMMIT_OVERRIDE

@andrewsg
andrewsg requested review from a teamDecember 11, 2024 16:58
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Dec 11, 2024
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Dec 11, 2024

@ddelgrosso1ddelgrosso1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsg
andrewsg merged commit 066be2d into mainDec 11, 2024
@andrewsg
andrewsg deleted the 3.0-filename-404-cleanup branch December 11, 2024 18:11
@release-pleaserelease-pleaseBot mentioned this pull request Dec 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blob.download_to_filename leaves empty file if not found

3 participants

@andrewsg@ddelgrosso1@cojenco