Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: filter download_kwargs in BlobReader - #1411

Merged
cojenco merged 2 commits into
googleapis:mainfrom
cojenco:filter-kwargs
Jan 22, 2025
Merged

fix: filter download_kwargs in BlobReader#1411
cojenco merged 2 commits into
googleapis:mainfrom
cojenco:filter-kwargs

Conversation

@cojenco

@cojencocojenco commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Fixes#1406 🦕

@cojenco
cojenco requested review from a teamJanuary 9, 2025 19:43
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Jan 9, 2025
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Jan 9, 2025
@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@cojencocojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2025
andrewsg
andrewsg approved these changes Jan 15, 2025
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojencocojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@cojenco
cojenco merged commit 0c21210 into googleapis:mainJan 22, 2025
@release-pleaserelease-pleaseBot mentioned this pull request Jan 22, 2025
Merged
cojenco added a commit that referenced this pull request Feb 4, 2025
@cojenco
fix: filter download_kwargs in BlobReader (#1411)
0780ea5
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andrewsgandrewsgandrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@andrewsgandrewsg

Labels

api: storageIssues related to the googleapis/python-storage API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to call seek when a BlobReader instance initialized with raw_download parameter

3 participants

@cojenco@andrewsg@yoshi-kokoro