Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
test: add retry for bucket cmek enabled system test - #245
Merged
Conversation
tseaver
suggested changes
Aug 14, 2020
tseaver
left a comment
Contributor
There was a problem hiding this comment.
Retrying the whole test to work around an eventual consistency problem is too heavy a hammer. Instead, we should add a loop below, e.g. at line 2027:
blob.upload_from_string(payload)
whileblob.kms_key_nameisNone:
time.sleep(1)
blob.reload()
# We don't know the current version of the key.self.assertTrue(blob.kms_key_name.startswith(kms_key_name))Or better yet, use one of the test_utils.retry utilities to accomplish that goal.
HemangChothani
commented
Aug 17, 2020
ContributorAuthor
tseaver
approved these changes
Aug 17, 2020
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#239
Tried to reproduce locally but no results so far, so adding a retry for the test to avoid flaky failures.