Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add classifiers for python3.9 and remove for python3.5 - #295

Merged
tseaver merged 9 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_292
Nov 13, 2020
Merged

feat: add classifiers for python3.9 and remove for python3.5#295
tseaver merged 9 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_292

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Towards #292

  • nox.py file is generated by synthtool, so didn't include changes here.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@HemangChothaniHemangChothani linked an issue Oct 15, 2020 that may be closed by this pull request
Add test pass, classifiers for Python 3.9 #292
Closed
@andrewsg

andrewsg commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Will this refuse to install on Python 2.7 or will it just no longer be recommended?

@frankynfrankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@tseaver

tseaver commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

@andrewsg The following will refuse to install on 2.7, at least with any recent setuptools:

python_requires=">=3.6",

This definitely needs to get merged as a breaking change.

@crwilcox

crwilcox commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

I'd recommend waiting to remove Python 2 until other breaking changes. At this time supporting Python 2 isn't providing any drag, but I think once it is we can remove it. @andrewsg@frankyn do we know of any changes that are also breaking to bundle?

tseaver
tseaver reviewed Nov 13, 2020
View reviewed changes
Comment threadnoxfile.py Outdated
Comment threadsetup.py
Comment threadsetup.py Outdated
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@tseavertseaver changed the title feat: add classifiers for python3.9 and remove for python2.7 and 3.5feat: add classifiers for python3.9 and remove for python3.5Nov 13, 2020
@tseavertseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
@tseaver
tseaver merged commit f072825 into googleapis:masterNov 13, 2020
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@frankyn
@tseaver@cojenco
feat: add classifiers for python3.9 and remove for python3.5 (googlea…
69942ca
…pis#295)
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@frankyn
@tseaver@cojenco
feat: add classifiers for python3.9 and remove for python3.5 (googlea…
47d666e
…pis#295)
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test pass, classifiers for Python 3.9

6 participants

@HemangChothani@andrewsg@tseaver@crwilcox@frankyn@yoshi-kokoro