Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: preserve metadata value - #298

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_293
Nov 11, 2020
Merged

fix: preserve metadata value#298
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_293

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Fixes#293

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@frankyn
frankyn requested review from andrewsg and removed request for frankynOctober 21, 2020 16:35
@frankyn

frankyn commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

@andrewsg PTAL when you have a moment.

tseaver
tseaver suggested changes Oct 21, 2020
View reviewed changes
Comment threadtests/unit/test_blob.py Outdated
Comment threadtests/unit/test_blob.py
@HemangChothani

HemangChothani commented Oct 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL!

@tseavertseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 5ab6b0d into googleapis:masterNov 11, 2020
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@cojenco
fix: preserve metadata value (googleapis#298)
1cb663b
Fixesgoogleapis#293
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@cojenco
fix: preserve metadata value (googleapis#298)
16145e4
Fixesgoogleapis#293
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
@andrewsgandrewsgAwaiting requested review from andrewsg
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blob.metadata not preserved when uploading new file content

3 participants

@HemangChothani@frankyn@tseaver