Uh oh!
There was an error while loading. Please reload this page.
refactor: move methods to client class - #311
Conversation
andrewsg
commented
Dec 1, 2020
@tswast In the bug you said, "we need to update samples for moved methods before deprecating the old ones." Is this change okay as-is, or do we need to make this change without the deprecation warning first, then update samples, then add the deprecation warning? |
tswast
commented
Dec 1, 2020
If it helps you find the samples that need to be updated, I'm okay merging this PR first. It's just a bad look if we have samples on cloud.google.com that show deprecation warnings. |
andrewsg
commented
Dec 1, 2020
I agree. But we can't update the sample without pushing part of this change, so @HemangChothani Let's omit the deprecation warning for now and open an issue to update the samples, then add the deprecation warning in that order. |
HemangChothani
commented
Dec 9, 2020
@andrewsg Opend an issue GoogleCloudPlatform/python-docs-samples#5031 to update the samples. |
HemangChothani
commented
Dec 16, 2020
@andrewsg I have opend an issue to update sample GoogleCloudPlatform/python-docs-samples#5031 in python-docs-sample repo , but i didn't find any sample needs to update, should i open issue in |
frankyn
commented
Dec 16, 2020
@andrewsg and @HemangChothani, I replied to the issue. We are only missing updates for download_to_filename. |
HemangChothani
commented
Dec 17, 2020
@frankyn we have moved
Also update the method call from |
frankyn
commented
Dec 17, 2020
Why was only download_to_file updated but not download_to_filename? |
HemangChothani
commented
Dec 17, 2020
Document mentioned in issue #38, found |
Fixes#38