Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: add change in 'Blob.custom_time' to changes - #323

Merged
tseaver merged 1 commit into
googleapis:masterfrom
haim0n:master
Nov 24, 2020
Merged

fix: add change in 'Blob.custom_time' to changes#323
tseaver merged 1 commit into
googleapis:masterfrom
haim0n:master

Conversation

@haim0n

Copy link
Copy Markdown
Contributor

This way '_PropertyMixin.patch' will send them to server.

Fixes#322 🦕

@google-cla

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Nov 22, 2020
@google-clagoogle-claBot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 22, 2020
@google-clagoogle-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 22, 2020
tseaver added a commit that referenced this pull request Nov 24, 2020
Also, add test assertions for 'metadata' setter for the same issue.
Closes#323

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

This way '_PropertyMixin.patch' will send them to server.
Fixesgoogleapis#322
@haim0n

Copy link
Copy Markdown
ContributorAuthor

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

done

@tseavertseaver added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 24, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2020
@tseavertseaver removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 24, 2020
@tseavertseaver changed the title fix: Add change in 'Blob.custom_time' to changesfix: add change in 'Blob.custom_time' to changesNov 24, 2020
@tseaver
tseaver merged commit 5174154 into googleapis:masterNov 24, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Blob.custom_time' setter doesnt update '_changes'

3 participants

@haim0n@tseaver@yoshi-kokoro