Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
refactor: add / use 'Client._get_resource' method - #431
Merged
gcf-merge-on-green[bot] merged 18 commits intoJun 7, 2021
Conversation
tseaver
marked this pull request as draft
May 5, 2021 21:27
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
2 times, most recently
from
May 6, 2021 17:10
aab3324 to
4f1110cComparetseaver
marked this pull request as ready for review
May 6, 2021 17:50
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 6, 2021 18:04
4bc1476 to
99e7e37Comparetseaver
marked this pull request as draft
May 6, 2021 20:01
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 6, 2021 21:01
3942d75 to
2103462Comparetseaver
marked this pull request as ready for review
May 6, 2021 21:03
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 7, 2021 17:50
2103462 to
794340aComparetseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 7, 2021 17:54
794340a to
9bae346Comparetseaver
commented
May 7, 2021
ContributorAuthor
Flaky systest reported in #435. Rerunning tests. |
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 10, 2021 15:24
9bae346 to
44eeeb4CompareFor use by API-invoking methods using the 'GET' method. Toward #38.
For parity with forthcoming '_put_resource', '_patch_resource', '_post_resource', and '_delete_resource' methods. Toward #38.
tseaverforce-pushed
the
38-refactor-api-methods-_helpers
branch
from
May 20, 2021 15:34
385f51d to
392343dCompare| method="GET", | ||
| path="%s/iam" % (self.path,), | ||
| info = client._get_resource( | ||
| "%s/iam" % (self.path,), |
There was a problem hiding this comment.
This is more of just a style thing, but in modern Python, should we be preferring str.format or f strings if Python 2 support has been dropped?
ContributorAuthor
There was a problem hiding this comment.
Once we drop Python2, I would definitely prefer f-strings.
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`. As a benefit, tests get *way* clearer. Toward googleapis#38 ~~Based on top of the branch from googleapis#430. I will rebase when that PR merges.~~
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`. As a benefit, tests get *way* clearer. Toward googleapis#38 ~~Based on top of the branch from googleapis#430. I will rebase when that PR merges.~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an explicit helper client method for
GETrequests, rather than manipulating client's private_connection.api_request. As a benefit, tests get way clearer.Toward #38
Based on top of the branch from #430. I will rebase when that PR merges.