Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

refactor: add / use 'Client._put_resource' method - #441

Merged
tseaver merged 6 commits into
masterfrom
38-refactor-client-_put_resource
Jun 7, 2021
Merged

refactor: add / use 'Client._put_resource' method#441
tseaver merged 6 commits into
masterfrom
38-refactor-client-_put_resource

Conversation

@tseaver

@tseavertseaver commented May 10, 2021

Copy link
Copy Markdown
Contributor

Toward #38.

Note: this PR is based on efd5a14 from PR #436. I will rebase to master when that PR lands. Done.

@tseaver
tseaver requested review from a team, andrewsg and crwilcoxMay 10, 2021 16:09
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label May 10, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@tseaver
tseaverforce-pushed the 38-refactor-client-_put_resource branch 3 times, most recently from ee8401e to 72fade3CompareMay 10, 2021 18:36
@tseaver
tseaver marked this pull request as draft May 10, 2021 18:38
@tseaver
tseaverforce-pushed the 38-refactor-client-_put_resource branch from afbf690 to cc9cb3dCompareJune 7, 2021 16:02
@tseaver
tseaver marked this pull request as ready for review June 7, 2021 16:02

@chrisrossichrisrossi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver
tseaver merged commit 3a8a920 into masterJun 7, 2021
@tseaver
tseaver deleted the 38-refactor-client-_put_resource branch June 7, 2021 19:26
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver@chrisrossi