Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
refactor: add / use 'Client._list_resource' method - #446
Merged
Conversation
tseaverforce-pushed
the
38-refactor-client-_list_resource
branch
from
June 8, 2021 16:57
0af1e83 to
5024d1fComparetseaver
marked this pull request as ready for review
June 8, 2021 16:57
Closed
Also, adjust tests for 'Bucket.list_blobs' not to depend on anything but calling 'Client.list_blobs'. Toward #38
Also, provide explicit coverage for 'client._item_to_bucket' and 'client._item_to_hmack_key_metadata' helpers. Toward #38
Also, provide explicit coverage for 'bucket._item_to_notification'. Toward #38
tseaverforce-pushed
the
38-refactor-client-_list_resource
branch
from
June 8, 2021 17:47
5024d1f to
68b762eComparecojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Adjust tests for 'Bucket.list_blobs' not to depend on anything but calling 'Client.list_blobs'. * Provide explicit coverage for 'client._item_to_bucket' and 'client._item_to_hmack_key_metadata' helpers. * Provide explicit coverage for 'bucket._item_to_notification'. Toward googleapis#38
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Adjust tests for 'Bucket.list_blobs' not to depend on anything but calling 'Client.list_blobs'. * Provide explicit coverage for 'client._item_to_bucket' and 'client._item_to_hmack_key_metadata' helpers. * Provide explicit coverage for 'bucket._item_to_notification'. Toward googleapis#38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #38.
Note: this PR is based on 2acfb06 of PR #443. I will rebase to master when that PR lands.Done.