Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
tests: move system tests into a package - #51
Merged
Conversation
tseaverforce-pushed
the
tests-port-gcp-9777
branch
from
February 11, 2020 22:20
4e4e810 to
bc1df28Compareplamut
reviewed
Feb 12, 2020
Comment on lines
+466
to
+459
| "logo": {"path": DATA_DIRNAME + "/CloudPlatform_128px_Retina.png"}, | ||
| "big": {"path": DATA_DIRNAME + "/five-point-one-mb-file.zip"}, | ||
| "simple": {"path": DATA_DIRNAME + "/simple.txt"}, |
Contributor
There was a problem hiding this comment.
Won't that be an error on Windows that use a different path separator?
(the change itself is good, referring to the existing state here)
Prep for factoring out e.g. signing tests into separate modules. Port of googleapis/google-cloud-python#9777 into new reposiory.
tseaverforce-pushed
the
tests-port-gcp-9777
branch
from
February 12, 2020 17:48
bc1df28 to
33c2407Comparetseaver
commented
Feb 12, 2020
ContributorAuthor
Ugh, new systest flake reported in #55. |
busunkim96
approved these changes
Feb 12, 2020
tseaver added a commit
that referenced
this pull request
Nov 10, 2020
tseaver added a commit
that referenced
this pull request
Nov 10, 2020
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Prep for factoring out e.g. signing tests into separate modules. Port of googleapis/google-cloud-python#9777 into new reposiory.
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Prep for factoring out e.g. signing tests into separate modules. Port of googleapis/google-cloud-python#9777 into new reposiory.
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for factoring out e.g. signing tests into separate modules.
Port of googleapis/google-cloud-python#9777
into new reposiory.