Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: use 120 sec timeout for 'blob.delete' during teardown - #518

Merged
tseaver merged 2 commits into
masterfrom
517-unflake-blobs_to_delete-teardown
Jul 22, 2021
Merged

tests: use 120 sec timeout for 'blob.delete' during teardown#518
tseaver merged 2 commits into
masterfrom
517-unflake-blobs_to_delete-teardown

Conversation

@tseaver

@tseavertseaver commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Closes#517

@tseaver
tseaver requested review from a team, andrewsg, cojenco, frankyn, tritone and tswastJuly 20, 2021 22:08
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Jul 20, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
cojenco
cojenco approved these changes Jul 22, 2021
View reviewed changes

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tseaver
tseaver merged commit 24ea536 into masterJul 22, 2021
@tseaver
tseaver deleted the 517-unflake-blobs_to_delete-teardown branch July 22, 2021 14:16
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver@cojenco
tests: use 120 sec timeout for 'blob.delete' during teardown (googlea…
e6fca0f
…pis#518)
Closesgoogleapis#517
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver@cojenco
tests: use 120 sec timeout for 'blob.delete' during teardown (googlea…
c30c37d
…pis#518)
Closesgoogleapis#517
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswasttswastAwaiting requested review from tswast
@andrewsgandrewsgAwaiting requested review from andrewsg
@frankynfrankynAwaiting requested review from frankyn
@tritonetritoneAwaiting requested review from tritone
1 more reviewer
@cojencocojencocojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teardown of blobs_to_delete fixture flakes with TimeoutError.

2 participants

@tseaver@cojenco