Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: make 'requests.exceptions.ChunkedEncodingError retryable by default - #526

Merged
tseaver merged 1 commit into
masterfrom
525-retry-requests-chunked-encoding-error
Jul 27, 2021
Merged

fix: make 'requests.exceptions.ChunkedEncodingError retryable by default#526
tseaver merged 1 commit into
masterfrom
525-retry-requests-chunked-encoding-error

Conversation

@tseaver

@tseavertseaver commented Jul 23, 2021

Copy link
Copy Markdown
Contributor

Closes#525.

@tseaver
tseaver requested review from a team and tswastJuly 23, 2021 19:25
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2021
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Jul 23, 2021
@andrewsg

andrewsg commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

I think this is googleapis/google-resumable-media-python#240 which can't be solved here in the client library - PR is in the works by @cojenco

@tseaver

tseaver commented Jul 27, 2021

Copy link
Copy Markdown
ContributorAuthor

@andrewsg I don't know whether the JSON API (versus the download API) can cause requests to perceive a ChunkedEncodingError -- I do know that the BigQuery API can emit them from JSON API calls (e.g, Client.list_rows(), see googleapis/python-bigquery#801).

andrewsg
andrewsg approved these changes Jul 27, 2021
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. Sounds like we may need it here too, then.

@tseaver
tseaver merged commit 4abb403 into masterJul 27, 2021
@tseaver
tseaver deleted the 525-retry-requests-chunked-encoding-error branch July 27, 2021 17:43
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver@cojenco
fix: make 'requests.exceptions.ChunkedEncodingError retryable by defa…
4cf6926
…ult (googleapis#526)
Closesgoogleapis#525.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver@cojenco
fix: make 'requests.exceptions.ChunkedEncodingError retryable by defa…
8514a93
…ult (googleapis#526)
Closesgoogleapis#525.
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswasttswastAwaiting requested review from tswast
1 more reviewer
@andrewsgandrewsgandrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make 'requests.exceptions.ChunkedEncodingError' retryable by default.

2 participants

@tseaver@andrewsg