Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: generate signed URLs for blobs/buckets using virtual hostname - #58

Merged
tseaver merged 4 commits into
masterfrom
10-v4-signing-virtual-hostname
Feb 13, 2020
Merged

feat: generate signed URLs for blobs/buckets using virtual hostname#58
tseaver merged 4 commits into
masterfrom
10-v4-signing-virtual-hostname

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Closes#10.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2020
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

Comment threadgoogle/cloud/storage/blob.py Outdated
version=None,
service_account_email=None,
access_token=None,
use_virtual_hostname=False,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use virtual_hosted_style instead.

Comment threadgoogle/cloud/storage/blob.py Outdated
@tseaver
tseaverforce-pushed the 10-v4-signing-virtual-hostname branch from 5e949f2 to 3be7f6eCompareFebruary 13, 2020 17:09
@tseaver
tseaverforce-pushed the 10-v4-signing-virtual-hostname branch from 3be7f6e to b75fd1dCompareFebruary 13, 2020 19:39
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver
tseaver merged commit 23df542 into masterFeb 13, 2020
@tseaver
tseaver deleted the 10-v4-signing-virtual-hostname branch February 13, 2020 20:32
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…oogleapis#58)
* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…oogleapis#58)
* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Storage] V4 Signature Support for virtual hosted-style signed

4 participants

@tseaver@frankyn@googlebot@yoshi-kokoro