Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: ensure config changes are propagated in sys tests - #870

Merged
cojenco merged 3 commits into
googleapis:mainfrom
cojenco:sys-conftest
Sep 23, 2022
Merged

tests: ensure config changes are propagated in sys tests#870
cojenco merged 3 commits into
googleapis:mainfrom
cojenco:sys-conftest

Conversation

@cojenco

@cojencocojenco commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

It seems like bucket config changes may not be propagated in time, resulting in flaky system tests.

  • refactor system tests to use preconfigured fixtures
  • rearrange tests with appropriate wait and test order
  • adjust max retries

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Sep 23, 2022
@cojenco
cojenco marked this pull request as ready for review September 23, 2022 19:55
@cojenco
cojenco requested review from a teamSeptember 23, 2022 19:55

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@cojenco
cojenco merged commit 2a6c162 into googleapis:mainSep 23, 2022
@cojenco
cojenco deleted the sys-conftest branch February 1, 2023 22:35
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cojenco@andrewsg