Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add predefined_acl to create_resumable_upload_session - #878

Merged
cojenco merged 2 commits into
googleapis:mainfrom
ddelange:patch-1
Oct 4, 2022
Merged

feat: add predefined_acl to create_resumable_upload_session#878
cojenco merged 2 commits into
googleapis:mainfrom
ddelange:patch-1

Conversation

@ddelange

@ddelangeddelange commented Sep 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#877 🦕

@ddelange
ddelange requested review from a teamSeptember 28, 2022 10:46
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Sep 28, 2022
@ddelangeddelange mentioned this pull request Sep 28, 2022
Closed
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 28, 2022
@ddelange
ddelangeforce-pushed the patch-1 branch 2 times, most recently from f2061fe to af06da0CompareSeptember 28, 2022 14:04
@ddelangeddelange mentioned this pull request Sep 28, 2022
Closed
5 tasks
@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@ddelange

ddelange commented Sep 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi @cojenco 👋

Could you re-run failed CI?

I copied over the qs_params addition from _do_multipart_success test helper, that should do the trick.

@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@ddelgrosso1ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@cojencocojenco changed the title Add predefined_acl to create_resumable_upload_sessionfeat: add predefined_acl to create_resumable_upload_sessionSep 29, 2022
@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
cojenco
cojenco approved these changes Sep 29, 2022
View reviewed changes

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@cojenco
cojenco merged commit 2b3e8f9 into googleapis:mainOct 4, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Oct 4, 2022
Merged
@ddelangeddelange mentioned this pull request Jul 29, 2024
Merged
5 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@cojencocojencocojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cojencocojenco

Labels

api: storageIssues related to the googleapis/python-storage API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support predefined_acl in create_resumable_upload_session

4 participants

@ddelange@cojenco@yoshi-kokoro@ddelgrosso1