Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add support for use_auth_w_custom_endpoint - #901

Merged
cojenco merged 6 commits into
googleapis:mainfrom
cojenco:custom-endpoint
Nov 29, 2022
Merged

feat: add support for use_auth_w_custom_endpoint#901
cojenco merged 6 commits into
googleapis:mainfrom
cojenco:custom-endpoint

Conversation

@cojenco

@cojencocojenco commented Nov 10, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This adds a boolean flag use_auth_w_custom_endpoint - whether authentication is required with custom endpoints

  • only used when a custom endpoint in set in conjunction
  • defaults to True and uses authentication
  • if set to False, bypasses authentication

For backwards compatibility

  • by default, auth is bypassed when STORAGE_EMULATOR_HOST is set

Fixes#895 and internal b/258502260

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Nov 10, 2022
frankyn
frankyn reviewed Nov 10, 2022
View reviewed changes
Comment threadgoogle/cloud/storage/client.py
@cojencocojenco added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 11, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 11, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2022
@cojenco
cojenco marked this pull request as ready for review November 15, 2022 00:21
@cojenco
cojenco requested review from a teamNovember 15, 2022 00:21
@cojencocojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
andrewsg
andrewsg approved these changes Nov 16, 2022
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question, otherwise LGTM. Thanks!

Comment threadgoogle/cloud/storage/client.py
@cojencocojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2022
@cojenco

cojenco commented Nov 17, 2022

Copy link
Copy Markdown
ContributorAuthor

Update: pending discussion with the GCS EngProd team to streamline usage and validate testing against non-prod environments

@cojencocojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@cojencocojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2022
@cojenco

cojenco commented Nov 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Synced offline with @rsaksham - prepod testing should not be affected by this change.

PR is ready to merge and release once freeze ends

@cojencocojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022
@cojenco
cojenco merged commit 4862a9c into googleapis:mainNov 29, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Nov 29, 2022
Merged
rsaksham added a commit to rsaksham/python-storage that referenced this pull request Nov 29, 2022
@rsaksham
Revert "feat: add support for use_auth_w_custom_endpoint (googleapis#901
c46a70d
)"
This reverts commit 4862a9c.
@cojencocojenco mentioned this pull request Nov 29, 2022
Closed
cojenco added a commit that referenced this pull request Nov 29, 2022
@cojenco
Revert "feat: add support for use_auth_w_custom_endpoint (#901)"
ba76344
This reverts commit 4862a9c.
@cojencocojenco mentioned this pull request Nov 29, 2022
Merged
cojenco added a commit that referenced this pull request Nov 29, 2022
@cojenco
Revert "feat: add support for use_auth_w_custom_endpoint (#901)" (#940)
1ca0233
This reverts commit 4862a9c.
@cojenco
cojenco deleted the custom-endpoint branch November 16, 2023 22:07
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@andrewsgandrewsgandrewsg approved these changes
@frankynfrankynfrankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable authentication when a non-default api_endpoint is set (just like the googleapis/nodejs-storage)

4 participants

@cojenco@andrewsg@frankyn@yoshi-kokoro