Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: add ThisObjectValue - #137

Merged
summer-ji-eng merged 17 commits into
masterfrom
this_object_value
Aug 1, 2020
Merged

feat: add ThisObjectValue#137
summer-ji-eng merged 17 commits into
masterfrom
this_object_value

Conversation

@summer-ji-eng

@summer-ji-engsummer-ji-eng commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

fullfill ThisObjectValue

  • Refer instance variable
  • Invoke class’s method with or without arguments
  • Return the referenced class

summer-ji-eng
summer-ji-eng commented Jul 28, 2020
View reviewed changes
Comment threadsrc/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java Outdated
miraleung
miraleung suggested changes Jul 29, 2020
View reviewed changes
Comment threadsrc/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java Outdated
Comment threadsrc/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java
Comment threadsrc/test/java/com/google/api/generator/engine/writer/JavaWriterVisitorTest.java Outdated
Comment threadsrc/test/java/com/google/api/generator/engine/writer/JavaWriterVisitorTest.java Outdated
miraleung
miraleung suggested changes Jul 30, 2020
View reviewed changes
Comment threadsrc/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java
Comment threadsrc/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java Outdated
miraleung
miraleung approved these changes Jul 31, 2020
View reviewed changes

@miraleungmiraleung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits addressed.

Comment threadsrc/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java Outdated
@summer-ji-eng
summer-ji-eng merged commit 7154d99 into masterAug 1, 2020
@summer-ji-eng
summer-ji-eng deleted the this_object_value branch September 14, 2020 22:40
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot@chingor13
deps: update dependency com.google.http-client:google-http-client-bom…
e5cae75
… to v1.34.1 (#137)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@miraleungmiraleungmiraleung approved these changes
@xiaozhenliu-gg5xiaozhenliu-gg5xiaozhenliu-gg5 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@summer-ji-eng@miraleung@xiaozhenliu-gg5