This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147

Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom
ChetHarrison:umd
Open

Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom
ChetHarrison:umd

Conversation

@ChetHarrison

@ChetHarrisonChetHarrison commented Oct 30, 2015

Copy link
Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈

@googlebot

googlebot commented Oct 30, 2015

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ChetHarrison

ChetHarrison commented Oct 30, 2015

Copy link
Copy Markdown
Author

I signed it!

@ChetHarrison

ChetHarrison commented Nov 2, 2015

Copy link
Copy Markdown
Author

hmm looks like I didn't run the linter. Hang on.

@googlebot

googlebot commented Nov 2, 2015

Copy link
Copy Markdown

CLAs look good, thanks!

@davideast

davideast commented Nov 5, 2015

Copy link
Copy Markdown
Contributor

Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.

@ChetHarrison

ChetHarrison commented Nov 5, 2015

Copy link
Copy Markdown
Author

Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.

I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.

@mbrevdambrevda mentioned this pull request May 11, 2016
Open
@mbrevda

mbrevda commented May 11, 2016

Copy link
Copy Markdown

@ChetHarrison were you able to get tests running for this?

@ChetHarrison

ChetHarrison commented May 12, 2016

Copy link
Copy Markdown
Author

Moshe,

Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.

Thanks

Chet

On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:

@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #147 (comment)

@mbrevda

mbrevda commented May 12, 2016

Copy link
Copy Markdown

It would be a huge help @ChetHarrison!

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

actually now that I think about it this shouldn't be to hard

@mbrevda

mbrevda commented May 13, 2016

Copy link
Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good
to get official support.

On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com
wrote:

actually now that I think about it this shouldn't be to hard

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#147 (comment)

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.

On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:

I would have, but your branch is a bit out of date. Also, it would be good
to get official support.

On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com
wrote:

actually now that I think about it this shouldn't be to hard

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#147 (comment)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #147 (comment)

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

1 down 2 to go

On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:

I would have, but your branch is a bit out of date. Also, it would be good
to get official support.

On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com
wrote:

actually now that I think about it this shouldn't be to hard

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#147 (comment)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #147 (comment)

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.

It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

done

@mbrevda

mbrevda commented May 13, 2016

Copy link
Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

@mbrevda I pushed my edits and tests to umd branch and PR'd

@ChetHarrison

ChetHarrison commented May 13, 2016

Copy link
Copy Markdown
Author

but it looks like Travis is cool with it

@taseenb

taseenb commented Oct 1, 2016

Copy link
Copy Markdown

This PM looks approved, when is it going to be merged?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 25, 2018. It is now read-only.

Added UMD wrapper - #147
Open
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Open
Added UMD wrapper#147
ChetHarrison wants to merge 2 commits into
googlearchive:masterfrom 
ChetHarrison:umd
Conversation
@ChetHarrison
@ChetHarrisonChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

I added the UMD wrapper so I could use backbonefire with my AMD project. It's on the "umd" branch. I tested by hand with RequireJS, CommonJS and Global implementations. I will write some tests for you next week but I thought I would check this in before the weekend hit. Happy Halloween. 😈
@googlebot
googlebot
commented
Oct 30, 2015

Copy link


Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@ChetHarrison
ChetHarrison
commented
Oct 30, 2015

Copy link


Copy Markdown

Author
I signed it!
@ChetHarrison
ChetHarrison
commented
Nov 2, 2015

Copy link


Copy Markdown

Author
hmm looks like I didn't run the linter. Hang on.
@googlebot
googlebot
commented
Nov 2, 2015

Copy link


Copy Markdown

CLAs look good, thanks!
@davideast
davideast
commented
Nov 5, 2015

Copy link


Copy Markdown

Contributor
Thanks for sending in the PR and signing the CLA! Give me a day or two to do a quick review but it looks really good! As for tests, please send those in too when you have some time.
@ChetHarrison
ChetHarrison
commented
Nov 5, 2015

Copy link


Copy Markdown

Author
Hey thanks for the all your work on the lib. I love the Firebase and plan on using it on my current project so I needed the AMD support anyway.
I will get to the tests. They will take some thought because I will need to set up some environment to get them to run. For example you, thoughtfully, have Backbone in your Bower and I will need an additional copy in the Node mods so I can test for the existence of Backbone.Firebase from the runner. So weird messy stuff like that. That said I did test all three configurations by hand.
@mbrevdambrevda
mentioned this pull request
May 11, 2016

Open

@mbrevda
mbrevda
commented
May 11, 2016

Copy link


Copy Markdown

@ChetHarrison were you able to get tests running for this?
@ChetHarrison
ChetHarrison
commented
May 12, 2016

Copy link


Copy Markdown

Author
Moshe,
Sorry I got distracted and it kinda fell off my plate. I’ll try and take a look at it again.
Thanks
Chet
On May 10, 2016, at 11:16 PM, Moshe Brevda notifications@github.com wrote:
@ChetHarrisonhttps://github.com/ChetHarrison were you able to get tests running for this?
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@mbrevda
mbrevda
commented
May 12, 2016

Copy link


Copy Markdown

It would be a huge help @ChetHarrison!
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda the quick fix is to grab my PR https://github.com/ChetHarrison/backbonefire. There is a lot of environment I need to think about in creating the common and amd tests that I am not a pro at but I think I can figure out. So If you are ok with that version I would get going with that while I address this.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
actually now that I think about it this shouldn't be to hard
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
yes I guess I did do it a while ago. They did want to add the PR but want the tests. I am working on them now.
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
1 down 2 to go
On May 12, 2016, at 10:33 PM, Moshe Brevda notifications@github.com wrote:
I would have, but your branch is a bit out of date. Also, it would be good

to get official support.
On Fri, May 13, 2016, 6:56 AM Chet Harrison notifications@github.com

wrote:
actually now that I think about it this shouldn't be to hard
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#147 (comment)
—

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub #147 (comment)
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
Ok I have some passing mocks but it's kinda cheating. I should pull some fixtures from actual module paradigms so we know if future changes to those paradigms break the tests. But much of this mod wars BS is going to sunset, thank what ever gods you like. So I think this may be a test suite.
It describes the conditions that are required to be present in order to branch to the appropriate module solution. Will PR soon.
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
done
@mbrevda
mbrevda
commented
May 13, 2016

Copy link


Copy Markdown

Thanks a ton @ChetHarrison! Would you want to merge the tests to the same branch as the PR?
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
@mbrevda I pushed my edits and tests to umd branch and PR'd
@ChetHarrison
ChetHarrison
commented
May 13, 2016

Copy link


Copy Markdown

Author
but it looks like Travis is cool with it
@taseenb
taseenb
commented
Oct 1, 2016

Copy link


Copy Markdown

This PM looks approved, when is it going to be merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ChetHarrison@googlebot@davideast@mbrevda@taseenb