Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Merge VerifyBamId to master. - #154

Merged
deflaux merged 7 commits into
googlegenomics:masterfrom
deflaux:master
Dec 3, 2015
Merged

Merge VerifyBamId to master.#154
deflaux merged 7 commits into
googlegenomics:masterfrom
deflaux:master

Conversation

@deflaux

@deflauxdeflaux commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

It still needs more testing to verify correctness of results, but it runs to completion successfully.

@googlebot

googlebot commented Dec 2, 2015

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

dionloy
dionloy reviewed Dec 2, 2015
View reviewed changes
Comment threadsrc/main/java/com/google/cloud/genomics/dataflow/pipelines/VerifyBamId.java Outdated

@dionloydionloyDec 2, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between "This" and "("

@deflauxdeflauxDec 3, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. It also needed a correction since the variantSet from which we get the allelic frequencies will generally not be in the same dataset as the reads.

@dionloydionloy assigned deflaux and unassigned dionloyDec 2, 2015
@deflauxdeflaux assigned dionloy and unassigned deflauxDec 3, 2015
@dionloy

dionloy commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

LGTM

Thanks!

deflaux added a commit that referenced this pull request Dec 3, 2015
@deflaux
Merge pull request#154from deflaux/master
78218e1
Merge VerifyBamId to master.
@deflaux
deflaux merged commit 78218e1 into googlegenomics:masterDec 3, 2015
@Careyjmac

Careyjmac commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

Randomly decided to check up on this, and noticed it finally got merged in! Yay! Hope everyone is doing well :)

@deflaux

deflaux commented Dec 9, 2015

Copy link
Copy Markdown
ContributorAuthor

Yeah @Careyjmac !!! Thanks again for this very cool pipeline and hope things are going great for you too!

jiridanek pushed a commit to jiridanek/dataflow-java that referenced this pull request Jan 18, 2016
@deflaux
Merge pull requestgooglegenomics#154from deflaux/master
930895c
Merge VerifyBamId to master.
@pgrosupgrosu mentioned this pull request Mar 29, 2016
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dionloydionloy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deflaux@googlebot@dionloy@Careyjmac