Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Refactor auth. - #159

Merged
deflaux merged 5 commits into
googlegenomics:masterfrom
deflaux:master
Dec 11, 2015
Merged

Refactor auth.#159
deflaux merged 5 commits into
googlegenomics:masterfrom
deflaux:master

Conversation

@deflaux

Copy link
Copy Markdown
Contributor
  • Pipelines now use Application Default Credentials by default.
  • FixesGet gRPC pipelines to run locally. #119
  • Since nearly all of these pipelines will be gRPC
    • Removed all usage of API Key for pipelines and integration tests.
    • Simplified pipeline options by no longer explicitly setting retries on the Genomics REST client, the default of 5 is used.

Note that the first commit in this PR was already reviewed as #158 but I could not merge that PR due to the other changes in util-java, which are taken care of by the second commit here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space between Scanner and (

@dionloy

Copy link
Copy Markdown
Contributor

LGTM, just that nit.

@deflaux

Copy link
Copy Markdown
ContributorAuthor

All integration tests have passed (Travis does not run those).

deflaux added a commit that referenced this pull request Dec 11, 2015
@deflaux
deflaux merged commit 89e3b23 into googlegenomics:masterDec 11, 2015
jiridanek pushed a commit to jiridanek/dataflow-java that referenced this pull request Jan 18, 2016
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@deflaux@dionloy