Uh oh!
There was an error while loading. Please reload this page.
Add Genomics API counters for Dataflow UI display. - #41
Conversation
coveralls
commented
Mar 11, 2015
coveralls
commented
Mar 11, 2015
pgrosu
commented
Mar 11, 2015
Hi Nicole, On line 122 in DataflowWorkarounds.java it is currently written as:
It would be preferred as follows, or maybe a variable that can be assigned:
~p |
pgrosu
commented
Mar 11, 2015
On line 125 of the same file, it is currently written as:
Could we expand it just for clarification purposes:
~p |
pgrosu
commented
Mar 11, 2015
Looks nice, I'll try it once merged. Thanks, |
Its now in the codelabs repository.
--machineType does not have a default of n1-standard-4 in all contexts.
Now that we are doing client-side filtering for strict shard boundaries, we need to ensure that we are requesting the field that the filter will check.
coveralls
commented
Mar 13, 2015
pgrosu
commented
Mar 13, 2015
Hi Nicole, Unfortunately it throws an error, since I cannot give it a range on a specific chromosome :( It wants a string for the reference, and I only want to count the reads within a specific range. Is there a solution? Thanks, |
iliat
commented
Mar 13, 2015
@pgrosu The API flavor of this pipeline was written as a very simplistic variant with just taking the reference and not ranges. The main purpose of this was to try the BAM file reading, not so much the API access. I will add more sophistication to the API side handling to make it compatible with what BAM reading part accepts. |
pgrosu
commented
Mar 13, 2015
Aha, thanks Ilia - I'll wait :) It was this part of the script that caused me think otherwise initially: if [ "$1"="bam" ];then
bam_argument="--BAMFilePath=$BAM_FILE_PATH"fiif [ "$2"="cloud" ];then
additional_arguments="--stagingLocation=${STAGING} --numWorkers=1 --runner=BlockingDataflowPipelineRunner"else
additional_arguments="--numWorkers=1"fiThanks, |
Add Genomics API counters for Dataflow UI display.
pgrosu
commented
Mar 13, 2015
Thanks Nicole :) |
Add Genomics API counters for Dataflow UI display.
Also: