Skip to content

feat(editor): add shortcut command controls - #54

Merged
byrongamatos merged 1 commit into
feat/eof-legacy-hotkeysfrom
feat/editor-shortcut-controls
Jul 5, 2026
Merged

byrongamatos merged 1 commit into
feat/eof-legacy-hotkeysfrom
feat/editor-shortcut-controls

Conversation

@ChrisBeWithYou

Copy link
Copy Markdown
Contributor

Summary

  • add a Shortcut Controls panel from the editor toolbar
  • list implemented shortcut-backed commands as clickable controls
  • show planned-but-unwired commands as disabled rows
  • keep EOF Legacy key labels accurate while avoiding overclaiming unfinished FeedBack-native bindings
  • cover command row metadata in the shortcut mapping tests

Testing

  • node --check screen.js
  • node tests/eof_shortcuts.test.js
  • all tests/*.test.js via node

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 508bf935-e09f-4a35-b718-28616ec54077

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/editor-shortcut-controls

Comment @coderabbitai help to get the list of available commands.

@byrongamatos

Copy link
Copy Markdown
Collaborator

Review pass (Claude Code). Clean, additive. The command catalog + _editorShortcutRowsPure + panel render are internally consistent: ready rows are clickable and dispatch through the shared _editorRunEofCommand runner (profile-independent — the panel is a clickable command palette, not keyboard-bound), planned rows are disabled (and editorRunShortcutCommand also guards them with a status message). The deliberate choice to surface only save's key for the FeedBack profile matches your stated intent (avoid overclaiming native bindings until #55 wires them) and is covered by the 'does not overstate' test. node --check + all JS tests green (7 shortcut tests). No change needed. (Codex unavailable this session — rate limit — manual + test-backed.)

@byrongamatos
byrongamatos force-pushed the feat/eof-legacy-hotkeys branch from 5ee923b to 232ae49 Compare July 5, 2026 12:24
@byrongamatos
byrongamatos force-pushed the feat/editor-shortcut-controls branch from 943a789 to f6ec576 Compare July 5, 2026 12:24
@byrongamatos
byrongamatos merged commit 48453fb into feat/eof-legacy-hotkeys Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants