-
Notifications
You must be signed in to change notification settings - Fork 38
feat(venue): reactive crowd video layer behind the 3D highway (career mode 1/3) #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78dbb03
feat(venue): reactive crowd video layer behind the 3D highway (career…
byrongamatos cab652d
fix(venue-crowd): retry renderer binding + preserve mid-stinger trans…
byrongamatos 5e5d892
fix(venue-crowd): per-video load tokens + unbind renderer on stop
byrongamatos 1172bc3
fix(venue-crowd): flush deferred loop on stinger failure, source accu…
byrongamatos de10e81
fix(venue-crowd): requeue mid-crossfade loops preempted by stingers; …
byrongamatos 9178959
fix(venue-crowd): generation-gate stinger handlers; recrop on video s…
byrongamatos 286a242
fix(venue-crowd): bail loop-fade completion when a stinger preempted …
byrongamatos c73ff96
fix(venue-crowd): keep rear video layer opaque during crossfades
byrongamatos c83fec2
fix(venue-crowd): reset active layer with mix on stop
byrongamatos f9a57ba
fix(venue-crowd): reset crowd mood to neutral on song load
byrongamatos be78b4f
fix(venue-crowd): cancel in-flight fade when a stinger preempts it
byrongamatos f362c9a
fix(venue-crowd): don't let null accuracy resets wipe the end-of-song…
byrongamatos 663e8ff
fix(venue-crowd): abort stale stinger state on song load
byrongamatos 9d8fda6
fix(venue-crowd): always detach load listeners, gate only the callback
byrongamatos 99812b8
feat(venue-crowd): flyover intro with crowd-ambience ducking
byrongamatos 4abdfb5
fix(venue-crowd): fall back to the loop when the intro fails to load
byrongamatos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: got-feedBack/feedBack
Length of output: 5832
Reset the crowd crop trackers on texture rebind
layer.lastAspect = 0only forces the plane fit;applyCoverCrop()is still skipped when the new<video>keeps the samevideoWidth/videoHeightas the previous source. ResetlastVidW/lastVidHhere so the freshVideoTexturegets cover-cropped once metadata lands.🤖 Prompt for AI Agents