Skip to content

Complete TrueHD DSI parsing when muxing to MP4 - #3863

Merged
rbouqueau merged 2 commits into
gpac:masterfrom
DolbyLaboratories:truehd_fix
Aug 30, 2026
Merged

Complete TrueHD DSI parsing when muxing to MP4#3863
rbouqueau merged 2 commits into
gpac:masterfrom
DolbyLaboratories:truehd_fix

Conversation

@MingxinChen

@MingxinChen MingxinChen commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Complete TrueHD DSI parsing when creating the MP4 TrueHD sample entry.

The format field is 4 bytes and the peak data rate field is 2 bytes. The previous implementation read these fields from incorrect offsets. This change fixes TrueHD metadata generation during MP4 muxing.

Testsuite PR: gpac/testsuite#72

@gpac-buildbot

Copy link
Copy Markdown
Contributor

Buildbot test results for revision: 26.08-DEV-rev44-g1e020edf-truehd-fix

❌ Tests failing on all platforms only on this branch:

test result
inspect-counter_english inspect-unframer:HashFail
mp4box-io-counter_english.mlp mp4-inspect:HashFail diso:HashFail add:HashFail
mp4box-io-truehd_ac3h.mlp mp4-inspect:HashFail diso:HashFail add:HashFail

As an indication here is the number of test fails by OS. A few random fails are excepted, however a big spike in numbers can warrant further investigation:

builder linux64 linux32 win64 win32 macos
fails 4 8 7 12 3
  • see full diff with master here
  • see full test results here

Please also make sure that the github checks below are not reporting any build issue.

@MingxinChen

Copy link
Copy Markdown
Contributor Author

Hi @aureliendavid , I've submitted a new testsuite PR #74 to fix the failing test cases caught by the changes in the value of format/peak_data_rate. Please take a look when you get a chance — happy to make any adjustments if needed.

@aureliendavid

Copy link
Copy Markdown
Member

/buildbot-rebuild

@gpac-buildbot

Copy link
Copy Markdown
Contributor

Buildbot test results for revision: 26.08-DEV-rev44-g1e020edf-truehd-fix

✅ No obvious regression from master, check the links below for full results

As an indication here is the number of test fails by OS. A few random fails are excepted, however a big spike in numbers can warrant further investigation:

builder linux64 linux32 win64 win32 macos
fails 1 3 5 7 1
  • see full diff with master here
  • see full test results here

Please also make sure that the github checks below are not reporting any build issue.

@aureliendavid

Copy link
Copy Markdown
Member

(note: I have not reviewed the changes to either the code or the hashes, I'll leave this to others, I just made the tests run)

@rbouqueau

Copy link
Copy Markdown
Member

LGTM, merging. Thank you @MingxinChen !

@rbouqueau
rbouqueau merged commit d0ffcae into gpac:master Aug 30, 2026
16 checks passed
rbouqueau added a commit to gpac/testsuite that referenced this pull request Aug 30, 2026
[testsuite sync] Complete TrueHD DSI parsing when muxing to MP4 (see gpac/gpac#3863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants