Complete TrueHD DSI parsing when muxing to MP4 - #3863
Conversation
Signed-off-by: Cecilia Chen <Cecilia.chen@dolby.com>
Buildbot test results for revision: 26.08-DEV-rev44-g1e020edf-truehd-fix❌ Tests failing on all platforms only on this branch: As an indication here is the number of test fails by OS. A few random fails are excepted, however a big spike in numbers can warrant further investigation:
Please also make sure that the github checks below are not reporting any build issue. |
|
Hi @aureliendavid , I've submitted a new testsuite PR #74 to fix the failing test cases caught by the changes in the value of format/peak_data_rate. Please take a look when you get a chance — happy to make any adjustments if needed. |
|
/buildbot-rebuild |
Buildbot test results for revision: 26.08-DEV-rev44-g1e020edf-truehd-fix✅ No obvious regression from master, check the links below for full results As an indication here is the number of test fails by OS. A few random fails are excepted, however a big spike in numbers can warrant further investigation:
Please also make sure that the github checks below are not reporting any build issue. |
|
(note: I have not reviewed the changes to either the code or the hashes, I'll leave this to others, I just made the tests run) |
|
LGTM, merging. Thank you @MingxinChen ! |
[testsuite sync] Complete TrueHD DSI parsing when muxing to MP4 (see gpac/gpac#3863)
Complete TrueHD DSI parsing when creating the MP4 TrueHD sample entry.
The format field is 4 bytes and the peak data rate field is 2 bytes. The previous implementation read these fields from incorrect offsets. This change fixes TrueHD metadata generation during MP4 muxing.
Testsuite PR: gpac/testsuite#72