Honor expire_time/tag when FanoutCache get/pop times out - #367
Open
vinson0522 wants to merge 2 commits into
Open
Honor expire_time/tag when FanoutCache get/pop times out#367vinson0522 wants to merge 2 commits into
vinson0522 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#354.
Cache.get/popwrap a missing-key default as(default, None)or(default, None, None)whenexpire_time/tagare set.FanoutCacheonly did that on the success path; aTimeoutorsqlite3.OperationalErrorreturned the bare default, sovalue, expire = cache.get(key, expire_time=True)crashed.Use the same wrap on the exception path for
getandpop.