Skip to content

feat: add .cjs config files - #161

Merged
benjie merged 2 commits into
graphile:mainfrom
andrew-w-ross:config-extensions
Jul 28, 2022
Merged

feat: add .cjs config files#161
benjie merged 2 commits into
graphile:mainfrom
andrew-w-ross:config-extensions

Conversation

@andrew-w-ross

Copy link
Copy Markdown
Contributor

Adds common js as a workaround for packages of type module.

@benjiebenjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; I think this is an acceptable solution for now. Please format the code so that it passes linting 👍

yarn lint:fix

In future, please use the pull request template.

@benjiebenjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks! 🙌

@benjie
benjie merged commit 09ccc7f into graphile:mainJul 28, 2022
@benjie

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@andrew-w-ross@benjie