Skip to content

Extend schema to allow for presigned URLs for uploading files - #108

Open
singingwolfboy wants to merge 13 commits into
graphile:mainfrom
singingwolfboy:upload-via-signed-url-extend-schema
Open

Extend schema to allow for presigned URLs for uploading files#108
singingwolfboy wants to merge 13 commits into
graphile:mainfrom
singingwolfboy:upload-via-signed-url-extend-schema

Conversation

@singingwolfboy

@singingwolfboysingingwolfboy commented Feb 12, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Follow-up to #107. This extends our GraphQL schema to expose a createUploadUrl mutation, which allows an API client to get a pre-signed URL for uploading a file to S3.

@singingwolfboysingingwolfboy mentioned this pull request Feb 13, 2020
Open
benjie
benjie requested changes Feb 24, 2020
View reviewed changes

@benjiebenjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, sorry about the delay - I've been busy on other projects.

Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts
@benjie

benjie commented Apr 20, 2020

Copy link
Copy Markdown
Member

CI is failing because aws-sdk was not added as a dependency of the relevant package.

benjie
benjie requested changes Apr 20, 2020
View reviewed changes

@benjiebenjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this PR 👍 I've left some more feedback.

Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
Comment thread@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated
This was referenced May 15, 2020
Closed
Draft
@benjie

benjie commented May 15, 2020

Copy link
Copy Markdown
Member

I tried to get this into a mergeable state in #167 but I ran out of time.

@benjie
benjie changed the base branch from master to mainJune 24, 2020 11:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjiebenjiebenjie requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@singingwolfboy@benjie