Skip to content

Fix yarn server schema:export command via makeSchema - #357

Merged
benjie merged 2 commits into
graphile:v5from
jamesallain:fix-schema-export
Mar 17, 2023
Merged

Fix yarn server schema:export command via makeSchema#357
benjie merged 2 commits into
graphile:v5from
jamesallain:fix-schema-export

Conversation

@jamesallain

Copy link
Copy Markdown
Collaborator

Description

Fix schema-export. I had to change the script to run it. cross-env wasn't working for me.

Performance impact

none

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@jamesallain

Copy link
Copy Markdown
CollaboratorAuthor

I think it's failing where You must set the I_SPONSOR_GRAPHILE environmental variable to the shared secret to use this pre-release software.

@benjiebenjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, apparently this file doesn't get type checked with everything else!

@benjiebenjie changed the title fixed file schema-export. Using makeSchema now.Fix yarn server schema:export command via makeSchemaMar 17, 2023
@benjie
benjie merged commit 61febc6 into graphile:v5Mar 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesallain@benjie