Int as_i32 feature for backward compliant GraphQL spec compliance

[ittorchbearer]

added as_i32 backward-compatible feature flag to allow running to GraphQL spec here: https://graphql.org/learn/schema/#scalar-types

[mathstuf]

Feature flags should be additive. We can still provide as_i64 even with an i32 because that has an impl Into.

[ittorchbearer]

I'll go through and change it around a bit. I leaned too heavily on minimal change over correctness.

…

On Thu, Apr 28, 2022, 7:43 PM Ben Boeckel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/common.rs <#65 (comment)> : > impl Number { + #[cfg(not(feature = "as_i32"))] Feature flags should be additive. We can still provide as_i64 even with an i32 because that has an impl Into. — Reply to this email directly, view it on GitHub <#65 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQTIR7TEHJNXGMZTK6UDX6TVHMPA3ANCNFSM5UTSF2HQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mathstuf]

FWIW, a CI job that runs with the feature flag would also likely be appreciated.

[jhult]

@ittorchbearer or @mathstuf, any update on this?

[mathstuf]

Waiting on updates from the author AFAIK.

[LegNeato]

Waiting on author changes

[LegNeato]

(@ittorchbearer FYI)

[danbi2990]

It's been a while. Can I open a new PR to address this issue?

[mathstuf]

Can I open a new PR to address this issue?

That's fine with me.